Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
consider using `find` to handle the case where its not in the map, otherwise it'll throw.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
same rationale for `push_back` vs `emplace_back` on `std::vector<std::unique_ptr<T>>` here: ```suggestion rootItems().insert(dummyScreen.identifier, std::make_unique<mixxx::qml::QmlMixxxContr...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
if possible it be nice if you can retain some structure (instead of quashing all into one) so its a little easier to review. It'd be nice if the abstract interfaces were in a separate commit to the...
m0dB created a review comment on a pull request on mixxxdj/mixxx
Thanks for spotting this. I will change this here and elsewhere. > I still highly appreciate that you're keeping this alive. It has been very interesting work, and I like seeing it becoming i...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
> I don't understand you proposal. Well currently you have ```cpp auto kColumnPropertiesByEnum[] = {}; auto kColumnPropertiesByEnum[] = {}; > I would like to treat this as a compiler fea...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Prolog isn't really a functional language though, its declaritive. If you're coming from the performance angle, I can recommend you to learn rust. Its amazing how nice code can look if its function...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
mappings themselves are in the majority of cases operating system agnostic.
Swiftb0y created a comment on an issue on mixxxdj/mixxx
should be almost plug-and-play. You don't even need an audio driver on linux. Just make sure to follow the audio setup instructions on the mixxx manual page above.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
see the exception for unique_ptr https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-consume ```suggestion void appendChildNode(std::unique_ptr<BaseNode> pNode) { T_Nod...
Swiftb0y created a review on a pull request on mixxxdj/mixxx
just quickly spotted this one and wanted to comment so I don't forget later. I still highly appreciate that you're keeping this alive.
Swiftb0y created a review on a pull request on mixxxdj/mixxx
just quickly spotted this one and wanted to comment so I don't forget later. I still highly appreciate that you're keeping this alive.
JoergAtGithub pushed 4 commits to 2.5 mixxxdj/mixxx
- ColorSchemeParser: move node finder to separate function d5cb1d3
- LegacySkinParser: look for LaunchImage style in configured color scheme 3c7400f
- LateNight/Shade: adjust LaunchImage style for color schemes d25b999
- Merge pull request #13731 from ronso0/launchimagestyle-per-color-scheme (skins) allow to set LaunchImage style per c... 9bd837e
JoergAtGithub closed a pull request on mixxxdj/mixxx
(skins) allow to set LaunchImage style per color scheme
A small, low-impact tweak. New look for **LateNight Classic**  **Shade Dark...
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
LGTM! Works as expected! A follow-up with support for LateNight64 Classic would be nice.
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
One thing to not though is that `new TypedArray(undefined)` still results in an empty array TypedArray, so for the most common usecase, it doesn't make a difference whether its returning an empty `...
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> However if you tell me it's fine to return an empty buffer as long as it's documented, then I'm fine with it. I think its fine, but we can also work together on the `undefined` return value. T...
christophehenry created a comment on a pull request on mixxxdj/mixxx
It's not that I want an array over `ArrayBuffer` , it's just that I really think the function should return `undefined` over empty buffer on encoding error. However if you tell me it's fine to retu...
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> I ended up writing an implementation using QJSValue and dumping the data in a JS array. WDYT? I'm not sure. IMO the same arguments against wrapping it in a `UInt8Array` apply here as well. If ...
JoergAtGithub created a branch on mixxxdj/mixxx
pr/13709 - Mixxx is Free DJ software that gives you everything you need to perform live mixes.
JoergAtGithub created a branch on mixxxdj/mixxx
PR_13709 - Mixxx is Free DJ software that gives you everything you need to perform live mixes.