Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

mixxxdj/mixxx

Swiftb0y created a review on a pull request on mixxxdj/mixxx

View on GitHub

Swiftb0y created a comment on an issue on mixxxdj/mixxx
mappings themselves are in the majority of cases operating system agnostic.

View on GitHub

Swiftb0y created a comment on an issue on mixxxdj/mixxx
should be almost plug-and-play. You don't even need an audio driver on linux. Just make sure to follow the audio setup instructions on the mixxx manual page above.

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx
CI passes, so LGTM. Thank you.

View on GitHub

Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
see the exception for unique_ptr https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-consume ```suggestion void appendChildNode(std::unique_ptr<BaseNode> pNode) { T_Nod...

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx
just quickly spotted this one and wanted to comment so I don't forget later. I still highly appreciate that you're keeping this alive.

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx
just quickly spotted this one and wanted to comment so I don't forget later. I still highly appreciate that you're keeping this alive.

View on GitHub

JoergAtGithub pushed 4 commits to 2.5 mixxxdj/mixxx
  • ColorSchemeParser: move node finder to separate function d5cb1d3
  • LegacySkinParser: look for LaunchImage style in configured color scheme 3c7400f
  • LateNight/Shade: adjust LaunchImage style for color schemes d25b999
  • Merge pull request #13731 from ronso0/launchimagestyle-per-color-scheme (skins) allow to set LaunchImage style per c... 9bd837e

View on GitHub

JoergAtGithub closed a pull request on mixxxdj/mixxx
(skins) allow to set LaunchImage style per color scheme
A small, low-impact tweak. New look for **LateNight Classic** ![Screenshot_2024-10-08_13-19-46](https://github.com/user-attachments/assets/8ffe606a-7465-4828-a068-f62ff90e17bc) **Shade Dark...
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
LGTM! Works as expected! A follow-up with support for LateNight64 Classic would be nice.

View on GitHub

JoergAtGithub opened a pull request on mixxxdj/mixxx
DjInterop PR #13709 with new VCPKG buildenv
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
One thing to not though is that `new TypedArray(undefined)` still results in an empty array TypedArray, so for the most common usecase, it doesn't make a difference whether its returning an empty `...

View on GitHub

Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> However if you tell me it's fine to return an empty buffer as long as it's documented, then I'm fine with it. I think its fine, but we can also work together on the `undefined` return value. T...

View on GitHub

christophehenry created a comment on a pull request on mixxxdj/mixxx
It's not that I want an array over `ArrayBuffer` , it's just that I really think the function should return `undefined` over empty buffer on encoding error. However if you tell me it's fine to retu...

View on GitHub

Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> I ended up writing an implementation using QJSValue and dumping the data in a JS array. WDYT? I'm not sure. IMO the same arguments against wrapping it in a `UInt8Array` apply here as well. If ...

View on GitHub

JoergAtGithub deleted a branch mixxxdj/mixxx

pr/13709

JoergAtGithub created a branch on mixxxdj/mixxx

pr/13709 - Mixxx is Free DJ software that gives you everything you need to perform live mixes.

JoergAtGithub deleted a branch mixxxdj/mixxx

PR_13709

JoergAtGithub created a branch on mixxxdj/mixxx

PR_13709 - Mixxx is Free DJ software that gives you everything you need to perform live mixes.

Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'm not sure if that works, but it be nice if you could experiment with it a little.

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx

View on GitHub

Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well in this case there should be because because were using only characters which are the same in ASCII and LATIN_9, right? For others you could manually create a string with the correct bytes `\x...

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx

View on GitHub

Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
At class scope, usually right below the `enum class` declaration. See [this example](https://compiler-explorer.com/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:c...

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx

View on GitHub

Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well, it can knows how to construct the qbytearray inplace while for the other other constructor it needs to jump into the Qt code. See [this example](https://compiler-explorer.com/#g:!((g:!((g:!((...

View on GitHub

Swiftb0y created a review on a pull request on mixxxdj/mixxx

View on GitHub

christophehenry created a comment on a pull request on mixxxdj/mixxx
I ended up writing an implementation using `QJSValue` and dumping the data in a JS array. WDYT?

View on GitHub

daschuer pushed 5 commits to 2.5 mixxxdj/mixxx
  • Reduced include scope from module include of QtQml by class include of QQmlEngine c1cad8c
  • Removed module wide include of QtSql and added class includes where necessary 81a7bd9
  • Removed module wide include of QtConcurrent and added sub includes where necessary 531a894
  • Removed module wide include of QtDbus and added class includes instead c767f7b
  • Merge pull request #13788 from JoergAtGithub/removeQtModuleHeaderIncludes_2.5 Replace module wide Qt includes to mak... 5a7b00a

View on GitHub

daschuer closed a pull request on mixxxdj/mixxx
Replace module wide Qt includes to make 2.5 compliant with Clazy 1.12
Closes: #13758
Load more