Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'm not sure if that works, but it be nice if you could experiment with it a little.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well in this case there should be because because were using only characters which are the same in ASCII and LATIN_9, right? For others you could manually create a string with the correct bytes `\x...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
At class scope, usually right below the `enum class` declaration. See [this example](https://compiler-explorer.com/#g:!((g:!((g:!((h:codeEditor,i:(filename:'1',fontScale:14,fontUsePx:'0',j:1,lang:c...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
well, it can knows how to construct the qbytearray inplace while for the other other constructor it needs to jump into the Qt code. See [this example](https://compiler-explorer.com/#g:!((g:!((g:!((...
christophehenry created a comment on a pull request on mixxxdj/mixxx
I ended up writing an implementation using `QJSValue` and dumping the data in a JS array. WDYT?
daschuer pushed 5 commits to 2.5 mixxxdj/mixxx
- Reduced include scope from module include of QtQml by class include of QQmlEngine c1cad8c
- Removed module wide include of QtSql and added class includes where necessary 81a7bd9
- Removed module wide include of QtConcurrent and added sub includes where necessary 531a894
- Removed module wide include of QtDbus and added class includes instead c767f7b
- Merge pull request #13788 from JoergAtGithub/removeQtModuleHeaderIncludes_2.5 Replace module wide Qt includes to mak... 5a7b00a
daschuer closed a pull request on mixxxdj/mixxx
Replace module wide Qt includes to make 2.5 compliant with Clazy 1.12
Closes: #13758
daschuer created a review on a pull request on mixxxdj/mixxx
All green, thank you for the likely tedious work. LGTM.
Ashankan opened an issue on mixxxdj/mixxx
External tempo sync request
### Feature Description I have been tempo syncing Mixxx with my DAW by looping an empty file in Deck-3 while sending tap tempo midi note from the DAW to the "tap tempo" and "set beat marker" funct...
JoergAtGithub opened a pull request on mixxxdj/mixxx
Replace module wide Qt includes to make 2.5 compliant with Clazy 1.12
Closes: #13758
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait, how can that work? There shouldn't be the same bytes in the two arrays 🤔
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait, where should I use `using enum WellKnownCharsets`?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I'm not sure I'm satisfied with empty array being the marker for an error. Are you sure there isn't a valid use case for returning an empty array? For instance passing an empty string? I know that ...
daschuer created a review comment on a pull request on mixxxdj/mixxx
Does it build with clang 15? I think the GCC headers are not compatible. https://askubuntu.com/questions/1525087/after-upgrading-ubuntu-to-24-04-lts-clang-does-not-work-properly Did you t...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Yes, clazy is based on clang. And the old clang version, where clazy 1.11 is based on does not the C++ features used in the Qt6.4 headers. clazy 1.12 is build on base of a recent clang version and ...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I wonder if this is a clang issue as well. Is this the issue we are fighting: https://github.com/JoergAtGithub/mixxx/actions/runs/11297991113/job/31426009871#step:9:1008
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'd prefer something like this: ```suggestion const auto result = evaluate(R"Javascript( engine.convertCharset(engine.WellKnownCharsets.LATIN_9, "Hello!")) )Javascript"); E...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
consider using `enum class` and `using enum WellKnownCharsets` to avoid implicit conversions to/from `int`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
please add another version check so we don't do the `utf8` conversion on >Qt6.8. Also `fromUtf8` is an incorrect name. It should be `fromUtf16` (which is what QStrings are encoded in).
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
just default-construct it (which is even nicely `constexpr`). If you return a nullptr, it will call [`QByteArray(char*, size = -1)`](https://doc.qt.io/qt-6/qbytearray.html#QByteArray-3) instead. Sa...