Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
daschuer created a review on a pull request on mixxxdj/mixxx
All green, thank you for the likely tedious work. LGTM.
Ashankan opened an issue on mixxxdj/mixxx
External tempo sync request
### Feature Description I have been tempo syncing Mixxx with my DAW by looping an empty file in Deck-3 while sending tap tempo midi note from the DAW to the "tap tempo" and "set beat marker" funct...
JoergAtGithub opened a pull request on mixxxdj/mixxx
Replace module wide Qt includes to make 2.5 compliant with Clazy 1.12
Closes: #13758
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait, how can that work? There shouldn't be the same bytes in the two arrays 🤔
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait, where should I use `using enum WellKnownCharsets`?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I'm not sure I'm satisfied with empty array being the marker for an error. Are you sure there isn't a valid use case for returning an empty array? For instance passing an empty string? I know that ...
daschuer created a review comment on a pull request on mixxxdj/mixxx
Does it build with clang 15? I think the GCC headers are not compatible. https://askubuntu.com/questions/1525087/after-upgrading-ubuntu-to-24-04-lts-clang-does-not-work-properly Did you t...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Yes, clazy is based on clang. And the old clang version, where clazy 1.11 is based on does not the C++ features used in the Qt6.4 headers. clazy 1.12 is build on base of a recent clang version and ...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I wonder if this is a clang issue as well. Is this the issue we are fighting: https://github.com/JoergAtGithub/mixxx/actions/runs/11297991113/job/31426009871#step:9:1008
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'd prefer something like this: ```suggestion const auto result = evaluate(R"Javascript( engine.convertCharset(engine.WellKnownCharsets.LATIN_9, "Hello!")) )Javascript"); E...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
consider using `enum class` and `using enum WellKnownCharsets` to avoid implicit conversions to/from `int`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
please add another version check so we don't do the `utf8` conversion on >Qt6.8. Also `fromUtf8` is an incorrect name. It should be `fromUtf16` (which is what QStrings are encoded in).
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
just default-construct it (which is even nicely `constexpr`). If you return a nullptr, it will call [`QByteArray(char*, size = -1)`](https://doc.qt.io/qt-6/qbytearray.html#QByteArray-3) instead. Sa...
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
I think just returning an empty QByteArray in the error case is fine.
Swiftb0y created a comment on an issue on mixxxdj/mixxx
I see how @daschuer's proposal could work. But its really easy to accidentally make mistakes with it IMO. If we get an `Inf` and only non-fast-math code interacts with in fast-math code, its probab...
JoergAtGithub pushed 2 commits to main mixxxdj/mixxx
JoergAtGithub closed a pull request on mixxxdj/mixxx
chore: pin Node.JS pre-commit hooks to use LTS
`nodeenv` (used by `pre-commit` to install Node env for pre-commit hooks using JavaScript) default to install the latest Node.JS runtime. v23.0.0 was just released and it contains [a bug](https:...
JoergAtGithub pushed 8 commits to 2.5 mixxxdj/mixxx
- Paintable: caching the rendered SVG. e045c83
- Do tiling and color adjustments after rendering the SVG in device pixel resolution. This also allows to remove the c... c3167df
- Narrow the QPixmapPainter scope, to not alter/redraw the pixmap with when a painter is still not descructed. 02137d8
- Resize cached pixmap for device pixel 606fd3e
- fix: make `hotcue_focus_color_next`/`_prev` COs `ControlPushButton`s This fixes two issues: 1. The Control is not ac... 866f37a
- Merge pull request #13764 from Swiftb0y/fix/hotcue_focus_color-signal fix: make `hotcue_focus_color_next`/`_prev` CO... ac33b83
- Merge pull request #13679 from daschuer/scaled_svg_cache Scaled svg cache 6c97ded
- Merge remote-tracking branch 'upstream/2.4' into 2.5 52c73ba
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
It can not compile the Qt6.4 headers, because of unsupported C++ features
daschuer created a review comment on a pull request on mixxxdj/mixxx
The goal should be to have a working clazy locally by default. I looked around to find a PPA for that but not yet found. Maybe we add this to our Launchpad PPA? What is the issue you trying to solv...