Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a comment on an issue on mixxxdj/mixxx
We had this discussion before. If you program in C++, you're not programming against the CPU, you're programming against the C++ abstract machine. The entire point is that the compiler is free to c...
daschuer created a comment on an issue on mixxxdj/mixxx
Think of CPU Registers and memory. Just because the CPU executed code compiled with fast-math there is no effect to thesese even if there are infinity values. The UB happens when the code interpr...
Eve00000 created a comment on a pull request on mixxxdj/mixxx
> This code was copied from the FFMPEG sounds source so it is probably impacting this one too. Shall we fix it as well? I don't know if this solution only fixes the problem on windows or also on...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
I rather meant just as a starting point where to poke at when you want to do a `git bisect`. Buf of course thats hard with a problem thats hard to reproduce...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'd recommend you to look a bit into functional programming. Learning Haskell is really eye opening ;) I can recommend learnyouahaskell.com
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
Depends on when we branched `main` (I don't remember of the top of my head). If we branched 2.5 after this pr got merged, it'll be in `2.5`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yup. Designated initializers are cool, but they deliberately work differently to allow for for example default arguments. I'm afraid there is no real way of achieving this trick in C++. You'll impl...
christophehenry created a comment on a pull request on mixxxdj/mixxx
Ok, so the `QJSValue` implementation don't pass the tests and make Mixxx segfault when using `convertCharset` in script, and the `QByteArray` don't let me return `undefined` on error… I'm a bit los...
acolombier created a comment on a pull request on mixxxdj/mixxx
This code was copied from the FFMPEG sounds source so it is probably impacting this one too. Shall we fix it as well?
Eve00000 opened a pull request on mixxxdj/mixxx
Solves problem with special characters in path to stems
This change solves the problem when special charactersare in the name of the directories containing stems. In my case ' •' See issue #13783.
daschuer created a review comment on a pull request on mixxxdj/mixxx
-( ``` Error: /home/runner/work/mixxx/mixxx/src/library/columncache.cpp:27:9: error: array designators are a C99 extension [-Werror,-Wc99-designator] [ColumnCache::COLUMN_LIBRARYTABLE_I...
daschuer created a review comment on a pull request on mixxxdj/mixxx
For my understanding this is the C++ 20 feature "designated initializers".
daschuer created a review comment on a pull request on mixxxdj/mixxx
Isn't this just a matter of alter include directives: https://github.com/KDE/clazy/blob/master/docs/checks/README-no-module-include.md I would prefer to fix the issue instead of disable the check.
daschuer created a review comment on a pull request on mixxxdj/mixxx
We should use our fpclassify.cpp instead.
daschuer created a review comment on a pull request on mixxxdj/mixxx
Do we have a reference for this, a Mixxx and a Ubuntu bug? This sounds like an issue we should solve in our https://github.com/daschuer/mixxx/blob/focal_main/tools/debian_buildenv.sh instead.
daschuer created a comment on a pull request on mixxxdj/mixxx
We have established our [Minimum-requirements-policy](https://github.com/mixxxdj/mixxx/wiki/Minimum-requirements-policy) after exchanging quite some arguments. One major argument for me was, the de...
m0dB created a comment on an issue on mixxxdj/mixxx
At these PRs or just at the code, since there is no guarantee this was introduced by any of these PRs... But It will be difficult to figure this out as it only happens occasionally... I will ask in...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Oh, no, wait, that code actually works! I'm so sorry for the noise…
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Okay, shooting a little in the dark here, but have you just tried `WellKnownCharsets.LATIN_9` in the JS? is it still `undefined`? Apart from that, try deleting the `engine.setProperty("WellKnown...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
this is unfortunately not valid C++.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
this deserves a utility function IMO.