Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Eve00000 opened a pull request on mixxxdj/mixxx
Solves problem with special characters in path to stems
This change solves the problem when special charactersare in the name of the directories containing stems. In my case ' •' See issue #13783.
daschuer created a review comment on a pull request on mixxxdj/mixxx
-( ``` Error: /home/runner/work/mixxx/mixxx/src/library/columncache.cpp:27:9: error: array designators are a C99 extension [-Werror,-Wc99-designator] [ColumnCache::COLUMN_LIBRARYTABLE_I...
daschuer created a review comment on a pull request on mixxxdj/mixxx
For my understanding this is the C++ 20 feature "designated initializers".
daschuer created a review comment on a pull request on mixxxdj/mixxx
Isn't this just a matter of alter include directives: https://github.com/KDE/clazy/blob/master/docs/checks/README-no-module-include.md I would prefer to fix the issue instead of disable the check.
daschuer created a review comment on a pull request on mixxxdj/mixxx
We should use our fpclassify.cpp instead.
daschuer created a review comment on a pull request on mixxxdj/mixxx
Do we have a reference for this, a Mixxx and a Ubuntu bug? This sounds like an issue we should solve in our https://github.com/daschuer/mixxx/blob/focal_main/tools/debian_buildenv.sh instead.
daschuer created a comment on a pull request on mixxxdj/mixxx
We have established our [Minimum-requirements-policy](https://github.com/mixxxdj/mixxx/wiki/Minimum-requirements-policy) after exchanging quite some arguments. One major argument for me was, the de...
m0dB created a comment on an issue on mixxxdj/mixxx
At these PRs or just at the code, since there is no guarantee this was introduced by any of these PRs... But It will be difficult to figure this out as it only happens occasionally... I will ask in...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Oh, no, wait, that code actually works! I'm so sorry for the noise…
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Okay, shooting a little in the dark here, but have you just tried `WellKnownCharsets.LATIN_9` in the JS? is it still `undefined`? Apart from that, try deleting the `engine.setProperty("WellKnown...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
this is unfortunately not valid C++.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
this deserves a utility function IMO.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Is this feature planned for 2.5?
christophehenry created a comment on a pull request on mixxxdj/mixxx
Should I add tests to this feature?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I tried that. It exposes an empty object. Here is the code I tried: ```diff diff --git a/src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp b/src/controllers/scripting/legacy/con...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
You may want to look into these PRs: https://github.com/mixxxdj/mixxx/pulls?q=is%3Apr+is%3Aclosed+author%3Adanferns
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
use `Q_ENUM`, its way simpler. https://stackoverflow.com/questions/59728876/how-to-register-an-enum-type-to-qjsengine-to-be-used-from-the-scripting-environm
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
if you want to return undefined, yes. you can also return an empty array buffer though.