Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Is this feature planned for 2.5?
christophehenry created a comment on a pull request on mixxxdj/mixxx
Should I add tests to this feature?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I tried that. It exposes an empty object. Here is the code I tried: ```diff diff --git a/src/controllers/scripting/legacy/controllerscriptenginelegacy.cpp b/src/controllers/scripting/legacy/con...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
You may want to look into these PRs: https://github.com/mixxxdj/mixxx/pulls?q=is%3Apr+is%3Aclosed+author%3Adanferns
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
use `Q_ENUM`, its way simpler. https://stackoverflow.com/questions/59728876/how-to-register-an-enum-type-to-qjsengine-to-be-used-from-the-scripting-environm
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
if you want to return undefined, yes. you can also return an empty array buffer though.
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> > could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version? > > How about this? This would prevent us to use new functionality. We introduced this ...
acolombier created a comment on a pull request on mixxxdj/mixxx
> could we support both 22.04 and 24.04, at least till we move to support the next Qt LTS version? How about this?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
> In the unlikely case a certain codec is not available we get an empty string No. Current implementation returns `undefinedè and I documented that it will return `undefined` if charset is unava...
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> * Ubuntu 24.04 doesn't rely on a LTS version of Qt That make no difference, because 6.2 LTS and 6.4 are both out of maintenance. 6.5 is the oldes Qt6 release where bugfixes will be develop...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I don't have demands for additional changes here, so that's fine. I just like to confirm that we are on the right track. @Holzhaus, can you confirm that as well?
daschuer created a comment on an issue on mixxxdj/mixxx
The solution is to add a wrapper for `infinity()` to pfclassyfy.cpp. We have already `is_infinity()` there which need to be used for the checks.
acolombier created a review comment on a pull request on mixxxdj/mixxx
I guess we could make the marker align on the previously set grid if quantize is on. IMO that makes sense indeed to guide users to keep, their beatgrid as aligned as possible. Could we please addr...
daschuer created a comment on a pull request on mixxxdj/mixxx
We may decide. I have no particular demand. It is at 2.5 because @uklotzde has picked that target. Since we just have moved strings, my hope is that Transifex fixes i automatically. If it fails a...
daschuer created a review comment on a pull request on mixxxdj/mixxx
The visuals are implications here. Right, here we are looking to the CO interface. I'm interested in the future plans to align our requirements. As I have understood with the new "beats_s...
acolombier created a comment on a pull request on mixxxdj/mixxx
Overall, I'm not sure this is a good idea to drop support for Ubuntu 22.04/Qt 6.2 LTS. A few reasons for that: - Ubuntu 24.04 doesn't rely on a LTS version of Qt - PopOS (which I appear to be using...
Eve00000 opened an issue on mixxxdj/mixxx
Error with Stems in directories with special symbols (Addendum to #13550)
### Bug Description I wanted to reorganize my library, put stems at the same place of the original. Importing the stem is no problem, opening (analyzing or player) makes Mixxx crash. Deduction...
JoergAtGithub pushed 5 commits to 2.4 mixxxdj/mixxx
- Paintable: caching the rendered SVG. e045c83
- Do tiling and color adjustments after rendering the SVG in device pixel resolution. This also allows to remove the c... c3167df
- Narrow the QPixmapPainter scope, to not alter/redraw the pixmap with when a painter is still not descructed. 02137d8
- Resize cached pixmap for device pixel 606fd3e
- Merge pull request #13679 from daschuer/scaled_svg_cache Scaled svg cache 6c97ded
JoergAtGithub closed a pull request on mixxxdj/mixxx
Scaled svg cache
This is on top of https://github.com/mixxxdj/mixxx/pull/13678 It is used to demonstrates a scaled SVG cache. @JoergAtGithub Can you benchmark that on your side. With manual testing I do not ...
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
Compiling this without -ffast-math as for FpClassify would remove the errors of cause. But I don't think this is a proper fix, as there seems to be no need to use slow math here.