Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
github-actions[bot] created a comment on a pull request on mixxxdj/mixxx
This PR is marked as stale because it has been open 90 days with no activity.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
This PR doesn't contain any visuals, so di'm not sure what you're suggesting. Let's please not extend the scope of this PR to visuals when @acombier already worked hard to split the visual stuff f...
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
Sure, sounds like a good follow up to this PR \*wink-wink\*.
daschuer created a review comment on a pull request on mixxxdj/mixxx
We have already a hack to find the resource files from a Mixxx source tree. https://github.com/mixxxdj/mixxx/blob/a716202b0b5bd6923d4d4438d62dba5060a19791/src/preferences/configobject.cpp#L46 ...
daschuer created a review comment on a pull request on mixxxdj/mixxx
That sounds good. I was talking about the visual presentation. What should happen visually if a change marker is set and what should happen if a beat map with change marker is loaded. My pr...
daschuer pushed 2 commits to 2.5 mixxxdj/mixxx
daschuer closed a pull request on mixxxdj/mixxx
Show wait cursor when re/loading a skin (not during startup)
Often enough when reloading a skin during develpoment I wait and wonder if the Ctrl+Shift+R hotkey triggered a reload. Now we see a wait cursor while the skin is being loaded, like when applying...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
You need to tell the JavaScript-Interpreter (QJSEngine) about it. Something like this: ```C++ void registerEnums(QJSEngine& engine) { qRegisterMetaType<mixxx::preferences::constants::Wel...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Dammit! I can't find how to expose this enum under `engine.WellKnownCharsets`. Can someone help me?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait, that doesn't translate into `undefined`. Am I really forced to use QJSValue as a return type?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Maybe `jsdoc/require-param-type` and `jsdoc/require-returns-type` should be disabled since we're docmenting tpyes using JS.
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
For the durationutiltest.cpp it's pretty easy to use max() instead. But for the FramePos I'm unsure. I would've fixed it, if I would understand this.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Plus, it's not as if it poses the risk of a crash. At worst, the function would return `undefined` and the mapping can propose an alternative behavior.
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> That'll limit us to a somewhat small common subset though. I don't think so, if you use a Qt build with the same ICU version, you will get always the same charsets. We just need to ensure, tha...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
It makes less sense to me but I won't fight on this and move to the `engine` object.
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
You reported this device disconnected message recently for another device, also with NixOs 24.05 in https://github.com/mixxxdj/mixxx/issues/13660 No one else reported this message until now. We ge...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
Do you have an idea on how to ensure we don't create an `Inf` anyway and construct a FramePos from it?
Swiftb0y created a comment on an issue on mixxxdj/mixxx
likely fairly straightforward to fix using `::max()` instead of `::infinity()`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
ah, yeah. I was interpreting the ```cpp rootItem->setParentItem(pScreen->quickWindow()->contentItem()); ``` line as transferring ownership, but thats obviously wrong on second look.
JoergAtGithub opened an issue on mixxxdj/mixxx
Use of infinity() in code compiled with -ffast-math ( durationutiltest.cpp & frametest.cpp )
### Bug Description If I compile with clang-tidy 18, I get the following errors, because we use infinity() in code that is compiled with option `-ffast-math`. And `-ffast-math` sets `-ffinite-math...