Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
For the durationutiltest.cpp it's pretty easy to use max() instead. But for the FramePos I'm unsure. I would've fixed it, if I would understand this.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Plus, it's not as if it poses the risk of a crash. At worst, the function would return `undefined` and the mapping can propose an alternative behavior.
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> That'll limit us to a somewhat small common subset though. I don't think so, if you use a Qt build with the same ICU version, you will get always the same charsets. We just need to ensure, tha...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
It makes less sense to me but I won't fight on this and move to the `engine` object.
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
You reported this device disconnected message recently for another device, also with NixOs 24.05 in https://github.com/mixxxdj/mixxx/issues/13660 No one else reported this message until now. We ge...
Swiftb0y created a comment on an issue on mixxxdj/mixxx
Do you have an idea on how to ensure we don't create an `Inf` anyway and construct a FramePos from it?
Swiftb0y created a comment on an issue on mixxxdj/mixxx
likely fairly straightforward to fix using `::max()` instead of `::infinity()`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
ah, yeah. I was interpreting the ```cpp rootItem->setParentItem(pScreen->quickWindow()->contentItem()); ``` line as transferring ownership, but thats obviously wrong on second look.
JoergAtGithub opened an issue on mixxxdj/mixxx
Use of infinity() in code compiled with -ffast-math ( durationutiltest.cpp & frametest.cpp )
### Bug Description If I compile with clang-tidy 18, I get the following errors, because we use infinity() in code that is compiled with option `-ffast-math`. And `-ffast-math` sets `-ffinite-math...
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> No, the API must guarantee to support the same charsets on all platforms and builds of Mixxx. That'll limit us to a somewhat small common subset though. Is that a price we're willing to pay? D...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah, but pre-commit only touches the lines in the diff.
Frotus created a comment on an issue on mixxxdj/mixxx
Hey funny thing. I never have ran into this issue before. I've ran dual monitors for over a decade at work and home. So there are applications that are written in a way (most of them) that do not r...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
I recommend main, as 2.5 is already close to release.
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> Should I expose `QStringConverter::availableCodecs()`/`QTextCodec::availableCodecs()` to JS too, so that developers can chek what is available on their environment? No, the API must guarantee ...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
The `engine` class is already there, and used for nearly every function in the mapping API other than raw IO. There is no overhead, just a different existing class.
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Every Mixxx installation must support each mapping. The mapping API must be stable accross installations. There is no problem, to add a long list of charsets to the positive list.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Should I expose `QStringConverter::availableCodecs()`/`QTextCodec::availableCodecs() to JS too, so that developers can chek what is available on their environment?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I think it makes sense since this is computing data that it supposed to be send through midi. Isn't it adding complexity to add yet another interface in the global object; in particular an interfac...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Meh. I'm not in favor of that. The idea is to allow controller developers to use charsets if available without having to open a PR to make it available. I can, however check against `QStringConvert...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
alternatively we just let the mapping handle it. Not sure whats better.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ah no, sorry. This was left from a previous experimentation. This must be removed.