Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
> No, the API must guarantee to support the same charsets on all platforms and builds of Mixxx. That'll limit us to a somewhat small common subset though. Is that a price we're willing to pay? D...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah, but pre-commit only touches the lines in the diff.
Frotus created a comment on an issue on mixxxdj/mixxx
Hey funny thing. I never have ran into this issue before. I've ran dual monitors for over a decade at work and home. So there are applications that are written in a way (most of them) that do not r...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
I recommend main, as 2.5 is already close to release.
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
> Should I expose `QStringConverter::availableCodecs()`/`QTextCodec::availableCodecs()` to JS too, so that developers can chek what is available on their environment? No, the API must guarantee ...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
The `engine` class is already there, and used for nearly every function in the mapping API other than raw IO. There is no overhead, just a different existing class.
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Every Mixxx installation must support each mapping. The mapping API must be stable accross installations. There is no problem, to add a long list of charsets to the positive list.
christophehenry created a comment on a pull request on mixxxdj/mixxx
Should I expose `QStringConverter::availableCodecs()`/`QTextCodec::availableCodecs() to JS too, so that developers can chek what is available on their environment?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
I think it makes sense since this is computing data that it supposed to be send through midi. Isn't it adding complexity to add yet another interface in the global object; in particular an interfac...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Meh. I'm not in favor of that. The idea is to allow controller developers to use charsets if available without having to open a PR to make it available. I can, however check against `QStringConvert...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
alternatively we just let the mapping handle it. Not sure whats better.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ah no, sorry. This was left from a previous experimentation. This must be removed.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Hmm… This is a `pre-commit` fix, isn't it?
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
> We have in one hand beat maps, where basically everything beat is a \"change marker\". On the other hand we have real \"bar changes\" (Taktwechsel) that would be annotated as a double bar line. ...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ok. this conversation is resolved then.