Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
So sometimes you do delete them and sometimes you don't. It would be really nice if you could fix those ownership issues here.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Ah, I just spotted it now. Well the problem is that we do call `delete` on it. So its very easy to mistake it as properly owning. I also fear that the pointer can easily outlive the RenderingEngine...
acolombier created a review comment on a pull request on mixxxdj/mixxx
Any reason why introducing a smart pointer on a Qt-owned reference here? Just in case you've missed the comment, the pointer is managed by the QML scene, we don't have any control over it.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
lets avoid introducing manual memory management. You can wrap this in a unique_ptr. If that doesn't work because QHash needs the key to be copy-able, use `std::unordered_map` instead.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
yeah, but I don't think its worth the complexity. Taking a quick glance at the source, there is no heap allocation or anything else expensive that is worth reusing. We can KISS for now and optimize...
nPrevail opened an issue on mixxxdj/mixxx
Bug: Traktor Kontrol X1 MK2 freezes and disconnects during use
### Bug Description I was running Mixxx, and using my Traktor X1 MK2 with a Traktor Audio 6 interface and a AKAI Midimix controller, when out of no where, my X1 MK2 freezes (lights stay on) and al...
ywwg created a comment on a pull request on mixxxdj/mixxx
for sure, we want to get this in and don't want to have forks that need maintenance. I do like the approach of using a controller setting to enable / disable the new API. That limits the blast radi...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
There's a `resetState` method that can be called first, though.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
> Oh no, since 6.4, the set is opened with `QStringConverter`. That's why my last commit uses `QTextCodec` prior to 6.4. Virtually any encoding supported by UCI should be available. See my last com...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Actually, there is probably a little more we can do here. Apparently there are more optional codecs available using [`QStringConverter::availableCodecs()`](https://doc.qt.io/qt-6/qstringconverter.h...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Oh no, since 6.4, the set is opened with `QStringConverter`. That's why my last commit uses `QTextCodec` prior to 6.4. Virtually any encoding supported by UCI should be available. See my last comme...
christophehenry created a comment on a pull request on mixxxdj/mixxx
Ok, so I can confirm this code works. 
christophehenry created a comment on a pull request on mixxxdj/mixxx
I can confirm, this code works on DN-S3700. 
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
you can take a QJSValue (which acts as a QVariant) and then switch internally depending on the type of the contained value. I'm not sure if that complexity is worth it though. I would prefer to hav...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I don't think so. From what I can tell (by only looking at the docs, not the source), it supports encoding in chunks instead of all at once, so it needs internal state there. That state should prob...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
only if the pointer returned is owning. Thats why plain pointers are bad, they could be owning or non-owning and you never know (nor can be sure either is always the case) because that information ...