Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Oh no, since 6.4, the set is opened with `QStringConverter`. That's why my last commit uses `QTextCodec` prior to 6.4. Virtually any encoding supported by UCI should be available. See my last comme...
christophehenry created a comment on a pull request on mixxxdj/mixxx
Ok, so I can confirm this code works. 
christophehenry created a comment on a pull request on mixxxdj/mixxx
I can confirm, this code works on DN-S3700. 
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
you can take a QJSValue (which acts as a QVariant) and then switch internally depending on the type of the contained value. I'm not sure if that complexity is worth it though. I would prefer to hav...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I don't think so. From what I can tell (by only looking at the docs, not the source), it supports encoding in chunks instead of all at once, so it needs internal state there. That state should prob...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
only if the pointer returned is owning. Thats why plain pointers are bad, they could be owning or non-owning and you never know (nor can be sure either is always the case) because that information ...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
You can technically execute some JS code in C++ that essentially does that and return the resulting QJSValue, but thats quite ugly IMO. I think it should up to the caller how they want to interpret...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
`QStringEncoder` and `QTextCodec` seem to allocate resources that can be reused. Is it a good idea, performance-wise, to cache them in a `QMap` or something?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
It seems like I can't `delete codec` because `QTextCodec` destrucotr is `protected`. Won't this cause a resource leak problem?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
So I can expose enums to `QJSEngine` but C++ enum only accepts ints as value. Is there a way that I can use strings as value or modify the signature of this function to accepts either a QString or ...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
No that was me. It correcty returns an `ArrayBuffer`. I just didn't know how to use it.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
`DecodedData` already has a `operator QByteArray()` and [that's what's documented](https://doc.qt.io/qt-6/qstringencoder.html#details).
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ah you're right. I expected a `TypedArray` and thus a `.forEach()`. So I'd need to do `new Uint8Array(midi.convertEncoding("ISO-8859-15", "Thing to display"))` from JS? Is there a way to directly r...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
maybe an explicit cast to QByteArray will fix it? ```suggestion QStringEncoder fromUtf16 = QStringEncoder(targetCharset.toUtf8().data()); if (!fromUtf16.isValid()) { ...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Maybe do some type introspection (`instanceof`) and if it is an `ArrayBuffer`.
Swiftb0y pushed 2 commits to main mixxxdj/mixxx
Swiftb0y closed a pull request on mixxxdj/mixxx
Fix Clazy v1.12 errors in main
This is the Follow-Up of https://github.com/mixxxdj/mixxx/pull/13769 addressing additional Clazy v1.12 errors in main