Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
You can technically execute some JS code in C++ that essentially does that and return the resulting QJSValue, but thats quite ugly IMO. I think it should up to the caller how they want to interpret...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
`QStringEncoder` and `QTextCodec` seem to allocate resources that can be reused. Is it a good idea, performance-wise, to cache them in a `QMap` or something?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
It seems like I can't `delete codec` because `QTextCodec` destrucotr is `protected`. Won't this cause a resource leak problem?
christophehenry created a review comment on a pull request on mixxxdj/mixxx
So I can expose enums to `QJSEngine` but C++ enum only accepts ints as value. Is there a way that I can use strings as value or modify the signature of this function to accepts either a QString or ...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
No that was me. It correcty returns an `ArrayBuffer`. I just didn't know how to use it.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
`DecodedData` already has a `operator QByteArray()` and [that's what's documented](https://doc.qt.io/qt-6/qstringencoder.html#details).
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ah you're right. I expected a `TypedArray` and thus a `.forEach()`. So I'd need to do `new Uint8Array(midi.convertEncoding("ISO-8859-15", "Thing to display"))` from JS? Is there a way to directly r...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
maybe an explicit cast to QByteArray will fix it? ```suggestion QStringEncoder fromUtf16 = QStringEncoder(targetCharset.toUtf8().data()); if (!fromUtf16.isValid()) { ...
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
Maybe do some type introspection (`instanceof`) and if it is an `ArrayBuffer`.
Swiftb0y pushed 2 commits to main mixxxdj/mixxx
Swiftb0y closed a pull request on mixxxdj/mixxx
Fix Clazy v1.12 errors in main
This is the Follow-Up of https://github.com/mixxxdj/mixxx/pull/13769 addressing additional Clazy v1.12 errors in main
daschuer created a comment on an issue on mixxxdj/mixxx
We have already the same for crates. Adding it for playlist should be no issue. https://github.com/mixxxdj/mixxx/blob/6efbf8cd83bd031dbb3d5e562fe4b863927cadd8/src/library/searchqueryparser.cpp#L84 ...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Please stay focused on the topic! Key changes and general music annotation are completely unrelated to this PR.
daschuer created a review comment on a pull request on mixxxdj/mixxx
Ok, I understand `beats_set_change_marker` is than a good fit. @Holzhaus, you post reveals another conceptual issue, it is worth noting: We have in one hand beat maps, where basically every...
daschuer closed a pull request on mixxxdj/mixxx
Mixxx 2.6-alpha-105-g5f1a710870 crashes on startup
Fixes #13746
dmitrrryyy opened a pull request on mixxxdj/mixxx
Mixxx 2.6-alpha-105-g5f1a710870 crashes on startup
Fixes #13746