Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
I agree with @JoergAtGithub that this sounds weird. `time_signature_change_marker` is also not a good fit, because this is *not about time signatures*. You can set a marker and have the same time s...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Maybe I've not understood everything and I'm not a native English speaker, but `beats_mark_bar_change` sounds strange to me. I think `time_signature_change_marker` or `time_signature_changing_beat`...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I think our minimum is still Qt 6.2. The proposed code will work with that, but probably with some issue fixed in Qt 6.4 as @JoergAtGithub pointed out. My proposal is this: If it turns out ...
acolombier created a comment on a pull request on mixxxdj/mixxx
Yeah I realised that it was regenerating a lot of stuff after commenting. But a CI job with profanity filter+auto merge sounds like the way to go.
Holzhaus created a comment on a pull request on mixxxdj/mixxx
> Having a PR with a quick diff could be an easier way to spot those  The diff is huge. However, we co...
Holzhaus created a comment on a pull request on mixxxdj/mixxx
> One question on PR - does it update the previously open PR or does it create a new one? I know renovate does that with deps update so I'm wondering if this is an option to reduce spam. It does...
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
For main the job takes 51 secs on my fork, see https://github.com/Holzhaus/mixxx/actions/runs/11354842443/job/31582931642
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
Are you > super nit-y, but [commitlint](https://github.com/conventional-changelog/commitlint) enforce the subject case to start with lower case by default. Are you sure about that? To me it l...
djantti created a comment on an issue on mixxxdj/mixxx
> Is jack/pipewire working with flatpack? Can you add libjack.so ? > > Can you also confirm the situation with libportdio.so Is it available for dynamic loading? At which part is it located? ...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Ok, so Qt6.4. Am I guaranteed that Mixxx will be compiled using Qt6.4 or should I add a default behavior when Mixxx is compiled with Qt<6.4.
davidlmorris created a review comment on a pull request on mixxxdj/mixxx
How anyone reads lambda functions with closure readable is beyond me anyway, so I have made the changes. And while I remain slightly concerned about performance, this is not the hill I would choos...
brianGriifin114 closed an issue on mixxxdj/mixxx
LegacyControllerMappingValidationTest.MidiMappingsValid ctest timeout under Address Sanitizer option.
### Bug Description Hey, We are MSVC test team and use Mixxx as part of the compiler testing. Recently we encountered an issue where the LegacyControllerMappingValidationTest.MidiMappingsValid tes...
acolombier created a comment on a pull request on mixxxdj/mixxx
@mixxxdj/developers what are you opinion about where this PR is aiming? I'm now at a stage where the mapping is pretty stable and usable. I appreciate that this introduce a huge amount of sourc...
acolombier created a review comment on a pull request on mixxxdj/mixxx
Consider using `reloop_toggle`
acolombier created a comment on a pull request on mixxxdj/mixxx
Closing in favour of #13653, which contains a more thorough implementation
acolombier closed a draft pull request on mixxxdj/mixxx
S4MK3: add support for STEM mixing
This feature depends on PRs related to the epic #13116
acolombier created a comment on a pull request on mixxxdj/mixxx
Closing in favour of #13653, which contains a more thorough implementation