Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
acolombier created a review comment on a pull request on mixxxdj/mixxx
I've added a free in the teardown. This pointer is owned by the QML scene. I have added a comment in the header file.
acolombier created a review comment on a pull request on mixxxdj/mixxx
@Swiftb0yare you happy to keep this work around as-is and create a follow up issue + `FIXME` comment?
acolombier created a review comment on a pull request on mixxxdj/mixxx
Looks like I still need to the `stuct` type
acolombier created a comment on a pull request on mixxxdj/mixxx
Note that this is still being actively worked on with @m0dB and myself!
acolombier created a review comment on a pull request on mixxxdj/mixxx
> Once we have a bar detection in place, we will probably have three states "guessed," "Detected by detector version x" and "manually confirmed". It sounds like something that will require to co...
acolombier created a review comment on a pull request on mixxxdj/mixxx
Happy with `beats_mark_bar_change` - does that work for you @Holzhaus ?
acolombier created a comment on a pull request on mixxxdj/mixxx
> Let's just rely on Transifex here and merge this blindly. I think it would be great to still have PR, even if we don't review them with as much involvement as we would do for code. We had a ca...
acolombier created a review comment on a pull request on mixxxdj/mixxx
I would almost vote too rare - how expansive is a run? (build time, bandwidth, ...)
acolombier created a review comment on a pull request on mixxxdj/mixxx
super nit-y, but [commitlint](https://github.com/conventional-changelog/commitlint) enforce the subject case to start with lower case by default. I know we don't use this linter and that `subject-c...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I wonder what the limitations are because from 6.0 the targetCharset name was passed directly as string to ICU. Since there is nothing written about the version dependency we may test if it works...
Holzhaus closed a draft pull request on mixxxdj/mixxx
Add spleeter effects
This is just a draft PR. I haven't succeeded integrating Spleeterpp yet, so I hope someone can help me out - [ ] Integrate Spleeterpp - [ ] Add effects separating the stems of the current signal
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
I looked it up, 6.4 is required, not 6.6. This is the version where support for ICU codecs was added: https://doc.qt.io/qt-6/whatsnew64.html
daschuer created a review comment on a pull request on mixxxdj/mixxx
QStringEncoder Is available from Qt 6.0, Which part requires Qt 6.6?
daschuer created a review comment on a pull request on mixxxdj/mixxx
The decision is made, once the user has adjusted the bars. There is no requirement to do this but when playing track the user should be able to know whether it is a confirmed 4/4 track where he can...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Yes, but you need to use Qt 6.6 or higher.
daschuer created a review comment on a pull request on mixxxdj/mixxx
I think you can use Qt6`s QStringEncoder