I don't fully agree with that. When/How would that decision be made? Manual intervention from the user for every single track is not an option because its infeasible with any reasonably sized library.
> you may also test the most recent 2.5-beta build, maybe we can isolate it to a specific version. https://downloads.mixxx.org/snapshots/2.5/mixxx-2.5-beta-60-g240033666f-macosarm.dmg
That versi...
> Only make the 4/4 assumption when upgrading from the legacy format to the new one.
Thats the point. We must not loose the "not decided state". I don't mind if the type can hold this state or n...
> I can't follow you here. Can you rephrase?
The idea was to default to zero in the invalid case, but I just noticed that the other types also don't do it. So my comment is void.
@daschuer Agreed, I did not open this PR to ensure manual reviews of translation PRs, just to make pulling translations easier and less work, and maybe we can do it more often.
> The allow list has currently 3755 lines with ~4 lines per string we will still almost 2000 lines. Still long.
Where does the 4 lines per string come from? With my proposal it would be 1 line per...
Same for validity tbh. If we don't use it currently, don't introduce the notion (but once you do need it, don't work around the lack of it by breaking the encapsulation (manually checking checking ...
> Than I would prefer to either use a the valid range or 0 as invalid and rejects everything else.
I can't follow you here. Can you rephrase?
> The question is open how to deal with the "defa...
Well, in other languages, it may be translated differently. I don't think we can make this blanket statement that its "Param EQ" in all languages. This concern applies to many strings here.
Thats not true. It matches both:
![image](https://github.com/user-attachments/assets/8932a738-fe31-4597-a212-2b6a619b0d66)
You need the negative lookbehind
![image](https://github.com/user-attac...
The allow list has currently 3755 lines with ~4 lines per string we will still almost 2000 lines. Still long.
Any custom format is not well defined, not extensible, without escape rules. While ...
I don't think that we can/will ever use this PR for review translations. The review needs to be done at Transifex by native speakers. Let's just rely on Transifex here and merge this blindly.
You...
Than I would prefer to either use a the valid range or 0 as invalid and rejects everything else.
The question is open how to deal with the "defaultet 4/4" state not sure if this a database only...
> Moreover 80ms is quite a lot...
ah okay, without the qdebug lines it's down to ~4ms for ~1600 widgets (LateNight).
I'll push the latest version soonish.