Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
daschuer created a review comment on a pull request on mixxxdj/mixxx
Ah OK, in is just a new grid start bar line. I thought this sets a bar line and then other bar lines are interpolated form that. The essence of my first comment is that "beats_set_marker" reads...
daschuer created a review comment on a pull request on mixxxdj/mixxx
Our QT vcpkg is build with "icu" https://github.com/daschuer/vcpkg/blob/5d58718e04ee9196314dc77d7cf414f36be24b65/ports/qtbase/vcpkg.json#L62
daschuer created a review comment on a pull request on mixxxdj/mixxx
Mmm interesting. It would be: ```suggestion std::optional<QStringEncoder> encoder = QStringEncoder::forName(targetCharset); if (!encoder) { return QJSValue::Undefi...
xxxmicrobexxx created a comment on an issue on mixxxdj/mixxx
I agree that this feature would be useful. When changing settings it is useful to have an easily accessible backup
brianGriifin114 created a comment on an issue on mixxxdj/mixxx
> What was the last commit, you compiled without this timeout? 9c6b16e in main branch
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
What was the last commit, you compiled without this timeout?
brianGriifin114 created a comment on an issue on mixxxdj/mixxx
Thanks for your attention. This problem occurred after we obtained and built the latest commit of Mixxx. Before the update, the timeout was 48 seconds and the build was successful. So I didn't expe...
github-actions[bot] created a comment on a pull request on mixxxdj/mixxx
This PR is marked as stale because it has been open 90 days with no activity.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
Custom parser would be straightforward: ```python def parse_allowlist(path: pathlib.Path) -> typing.Iterable[tuple[str, list[str]]: with path.open(mode="r") a fp: for line in fp: sourc...
daschuer created a comment on a pull request on mixxxdj/mixxx
pre-commit takes care that the check is only done if one is committing changes to the ts files. This is the right moment to reject false translations. > Because you cannot really fix the commit...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I have not much interest to write a custom parser. Can we decide for an established format. > not sure if we really want this Can you confirm the issue? Is there a alternative to distinguish...
JoergAtGithub created a comment on an issue on mixxxdj/mixxx
This test is one of our largest unit test and barely maintable anyway. Some time ago I started a PR to split it into multiple test runs, executing the same test case with the mapping script file as...
daschuer created a review comment on a pull request on mixxxdj/mixxx
all ts files are excluded but not "d.ts" files so it should be OK
Holzhaus created a comment on a pull request on mixxxdj/mixxx
In that case I'm questioning if we really want to check it on pull/during committing. Can this somehow be prevented on transifex? Or maybe a monthly check which opens a github issue if necessary?
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
If we really want an allow list (not sure if we really want this), let's use a plain text file with one source per line, followed by a tab character and then a comma separated list of fnmatch expre...
daschuer created a comment on a pull request on mixxxdj/mixxx
Yes, it is a manual think from a user. If they are too lazy and like to gain some more percentage they seems to just copy the source strings.
daschuer created a review comment on a pull request on mixxxdj/mixxx
For my understanding the reasons why xml is painful to review is if a tool restructures it. This should not happen here, because additional texts are appended. I have picked XML, because the ts f...
daschuer created a review comment on a pull request on mixxxdj/mixxx
What do you mean? Any suggestion?
Holzhaus created a comment on a pull request on mixxxdj/mixxx
> Do I see it correct, that compilation of all .ts files together need only 2 seconds CI time? If yes I would suggest to move this step in the normal build and get rid of the binary files stored in...
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
For a PR review, neither the .qm files(binary) nor the .ts files (huge because of line number changes) are suitable. Maybe we should generate a simple text file with just 2 columns out of each .ts...
JoergAtGithub created a comment on a pull request on mixxxdj/mixxx
Do I see it correct, that compilation of all .ts files together need only 2 seconds CI time? If yes I would suggest to move this step in the normal build and get rid of the binary files stored in t...