Ah OK, in is just a new grid start bar line. I thought this sets a bar line and then other bar lines are interpolated form that.
The essence of my first comment is that "beats_set_marker" reads...
Mmm interesting. It would be:
```suggestion
std::optional<QStringEncoder> encoder = QStringEncoder::forName(targetCharset);
if (!encoder) {
return QJSValue::Undefi...
Thanks for your attention. This problem occurred after we obtained and built the latest commit of Mixxx. Before the update, the timeout was 48 seconds and the build was successful. So I didn't expe...
Custom parser would be straightforward:
```python
def parse_allowlist(path: pathlib.Path) -> typing.Iterable[tuple[str, list[str]]:
with path.open(mode="r") a fp:
for line in fp:
sourc...
pre-commit takes care that the check is only done if one is committing changes to the ts files. This is the right moment to reject false translations.
> Because you cannot really fix the commit...
I have not much interest to write a custom parser. Can we decide for an established format.
> not sure if we really want this
Can you confirm the issue? Is there a alternative to distinguish...
This test is one of our largest unit test and barely maintable anyway. Some time ago I started a PR to split it into multiple test runs, executing the same test case with the mapping script file as...
In that case I'm questioning if we really want to check it on pull/during committing.
Can this somehow be prevented on transifex? Or maybe a monthly check which opens a github issue if necessary?
If we really want an allow list (not sure if we really want this), let's use a plain text file with one source per line, followed by a tab character and then a comma separated list of fnmatch expre...
For my understanding the reasons why xml is painful to review is if a tool restructures it. This should not happen here, because additional texts are appended.
I have picked XML, because the ts f...
> Do I see it correct, that compilation of all .ts files together need only 2 seconds CI time? If yes I would suggest to move this step in the normal build and get rid of the binary files stored in...
For a PR review, neither the .qm files(binary) nor the .ts files (huge because of line number changes) are suitable.
Maybe we should generate a simple text file with just 2 columns out of each .ts...
Do I see it correct, that compilation of all .ts files together need only 2 seconds CI time? If yes I would suggest to move this step in the normal build and get rid of the binary files stored in t...