Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
This will run on the first day of every month at 12 a.m. Is is too often? Or too rare? Suggestions welcome.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
```suggestion chore(translations): Pull ${{ matrix.branch }} branch from Transifex ```
Holzhaus opened a draft pull request on mixxxdj/mixxx
ci(actions): Update translations automatically
This automatically fetches translations from transifex, compiles them and then opens a PR to merge them. See https://github.com/Holzhaus/mixxx/pull/25 for an example PR that was opened by the bot. ...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
Unfortunately this nice API was replaced in Qt6 by QStringConverter, which supports much less codecs. The old API is still available in the "Qt 5 Core Compat module" for Qt6, but I guess this is no...
daschuer created a comment on a pull request on mixxxdj/mixxx
I am very much interested to get this PR merged. My plan was to move the features into single PRs to make them review-able. But I got dragged away. Any help is welcome. My current priority is to re...
Holzhaus created a comment on a pull request on mixxxdj/mixxx
One sec. I think this is actually lacking the instruction from gitattributes
acolombier created a comment on a pull request on mixxxdj/mixxx
With the landing of stem support in Mixxx, how would you guys feel about closing that PR? This feel slightly out of date and probably not aiming in the right direction anymore. I'm also not sure th...
acolombier created a review comment on a pull request on mixxxdj/mixxx
I'm wondering if we could just go with this in a first place, and then introduce the new proto definition if it does turns out to break something. After all, that is what alphas are for ;-)
daschuer created a review comment on a pull request on mixxxdj/mixxx
Qt has a wrapper for all this. I think it should be: ```suggestion QTextCodec* codec = QTextCodec::codecForName(targetCharset); if (!codec) { return QJSValue::Undef...
acolombier created a review comment on a pull request on mixxxdj/mixxx
I think it makes sense to keep the clear distinction between markers and bars/downbeat as @Holzhaus rightfully pointed out. There is is also the fact that marker define a new grid, so in the case w...
acolombier created a review comment on a pull request on mixxxdj/mixxx
I am not sure to be honest - the first version was falling back to the default value. However, I guess it semantically makes sense for a `BeatsPerBar` to be invalid if instantiated from an in out o...
acolombier created a review comment on a pull request on mixxxdj/mixxx
Fixed - used with debug operator
acolombier created a review comment on a pull request on mixxxdj/mixxx
We can - The double-beat mechanism is only used if a marker (or a bar length) was explicitely set.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
right, then try `QString::utf16()`.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
kind of. I'd add some checks though. like `static_assert(sizeof(ushort) == sizeof(UChar) && std::is_signed_v<ushort> == std::is_signed_v<UChar> && std::is_convertible_v<ushort, UChar>)`. Not sure t...