Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Swiftb0y created a review comment on a pull request on mixxxdj/mixxx
I'm not sure I like this allowlist approach. There are many strings which are debatable and having to maintain this giant list is not great either.
christophehenry created a review comment on a pull request on mixxxdj/mixxx
Wait… `QString::utf16()` returns `const ushort *` while `ucnv_fromUChars` expects `UChar*` as input and `char*` as output. How can that work? Can I just `(UChar*)QString::utf16()` and `(char*) myQB...
daschuer created a review comment on a pull request on mixxxdj/mixxx
I agree that 4/4 is the default and that we should not require people to set that. Can we later distinguish if the track has the guessed 4/4 setting or confirmed and start adjusted setting? Thi...
christophehenry created a review comment on a pull request on mixxxdj/mixxx
`ucnv_openU` won't work. `QString::data()` returns `QChar*`.
daschuer created a review comment on a pull request on mixxxdj/mixxx
> You don't need to set every bar line manually That's clear, but you also set at least the first. And it is about the alignment of the bars. So I think my proposal is not completely wrong. ...
JoergAtGithub created a review comment on a pull request on mixxxdj/mixxx
BeatsPerBar is self descriptive and clear to me
Swiftb0y created a comment on a pull request on mixxxdj/mixxx
Great thanks. Lets give everyone 24h to object before we merge.
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
To be honest, I think 4/4 is a reasonable assumption. Otherwise you'd require people to explicitly edit the beatgrid for every single track. I'm more worried about the default downbeat location, be...
Holzhaus created a review comment on a pull request on mixxxdj/mixxx
This is not the same. You don't need to set every bar line manually, they are interpolated based on the position of the marker and the BPM. The "Marker" is the frame position where the first downbe...
daschuer created a review comment on a pull request on mixxxdj/mixxx
> I appreciate it may feel a bit complicated, but that was the only way I could reuse the existing proto definition and make that change non-breaking I like the idea to have a compatible format....
Holzhaus created a comment on a pull request on mixxxdj/mixxx
Or I'll just rebase onto 2.4 to be on the safe side.
Holzhaus created a comment on a pull request on mixxxdj/mixxx
> Does it matter which branch this goes into? does still run the 2.4->2.5 job if it only lands in main? IIRC it suffices to have it in the default branch (`main`), but I'll double check on the p...