Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
... the name **of** all prisons Filtering on active ... (uppercase F)
jnioche-jd created a review on a pull request on ministryofjustice/prison-register
Minor changes to the descrption required
jnioche-jd created a review on a pull request on ministryofjustice/prison-register
Minor changes to the descrption required
marcusaleman deleted a branch ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison-backup
marcusaleman created a review comment on a pull request on ministryofjustice/prison-register
CsvSource to parametize the tests with the given results as you have suggested @jnioche-jd
marcusaleman created a review comment on a pull request on ministryofjustice/prison-register
@Mjwillis added your map filtering to use the refactorization of MAP-1727
marcusaleman opened a pull request on ministryofjustice/prison-register
Map 1673 add endpoint to return only name given prison
It reuses /prisons/names endpoint and resource and active and non active parameter This gives us more capabilities in a single endpoint. Parametes active & prison_id (they are not required) As an ...
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-clean-merge - Prison register
marcusaleman deleted a branch ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison-backup2
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison-backup2 - Prison register
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison-backup - Prison register
marcusaleman deleted a branch ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison-main
Mjwillis created a review comment on a pull request on ministryofjustice/prison-register
Use: ```kotlin fun getPrisonNames(active: Boolean?, prisonId: String?): List<PrisonNameDto> { return prisonRepository.findByActiveOrderByPrisonId(active = active) .filter { prisonI...
renovate[bot] pushed 2 commits to renovate-all-gradle-minor-patch ministryofjustice/prison-register
Mjwillis pushed 1 commit to main ministryofjustice/prison-register
- MAP-1727 Remove the eager multiple sql calls when loading a list of prisons (or a few or one) (#281) 79c8537
marcusaleman created a review on a pull request on ministryofjustice/prison-register
as there are some changes related to a ticket which is in a Pull Request, can we discuss about this?. fun used in MAP-1673 by the getPrisonNames is removed @Mjwillis @jnioche-jd
marcusaleman created a review on a pull request on ministryofjustice/prison-register
as there are some changes related to a ticket which is in a Pull Request, can we discuss about this? @Mjwillis @jnioche-jd
marcusaleman pushed 2 commits to MAP-1673-Add-endpoint-to-return-only-name-given-prison ministryofjustice/prison-register
marcusaleman pushed 1 commit to MAP-1673-Add-endpoint-to-return-only-name-given-prison ministryofjustice/prison-register
- MAP-1673 parameterized tests for all positive and negative scenarios b6c194e
marcusaleman created a review comment on a pull request on ministryofjustice/prison-register
I will check about this
marcusaleman created a review comment on a pull request on ministryofjustice/prison-register
I left 'name' cause the Resource is names to get the same information. but i can refactor this to prisonid something I thought previously.