Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Mjwillis created a review comment on a pull request on ministryofjustice/prison-register
This is confusing, isn't `name` the name of the prison? e.g. HMP Moorland. The `prisonId` would be `MDI` why is the parameter called `name`?
Mjwillis created a review comment on a pull request on ministryofjustice/prison-register
I don't like this approach, we would normally use a Specification for filters like this. There isn't really a need to write JQL - you can simply load the entity and then map to a Dto. The JPA ent...
Mjwillis created a review on a pull request on ministryofjustice/prison-register
Please use ```kotlin prisonRepository.findByActiveOrderByPrisonId(active = true).map { PrisonNameDto(it.prisonId, it.name) } ```
Mjwillis created a review on a pull request on ministryofjustice/prison-register
Please use ```kotlin prisonRepository.findByActiveOrderByPrisonId(active = true).map { PrisonNameDto(it.prisonId, it.name) } ```
ashleygyngell closed an issue on ministryofjustice/prison-register
Missing prison categories
Some of the prisons are missing categorisation. The table below shows the categories for some of the missing fields: | prisonId | prisonName | categories | | -------- | -----------...
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
good idea but why not go 1 step further and put the expected answers as parameters too?
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
what do you gain from having this test when you test for exactly the same thing as part of the tests below with `null, WDI` ?
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
calling the input **name** is just confusing given that this is also what we get as output. What we filter on is a **prison_id**
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
make it easier for the reader and add a comment explaining that WDI is an active prison and WOI isn't
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
this description is not clear what about > Return the names of all prisons if the parameter is not set, otherwise return only the one corresponding to the code. The filtering on active still app...
jnioche-jd created a review comment on a pull request on ministryofjustice/prison-register
change to "get prison name(s) " ?
marcusaleman created a review comment on a pull request on ministryofjustice/prison-register
As I have used /names resource, i don't need to create a new endpoint+resource as parameters manage this new scenario.
marcusaleman pushed 1 commit to MAP-1673-Add-endpoint-to-return-only-name-given-prison ministryofjustice/prison-register
- MAP-1673 test to return name or empty result paramatizared test for a given prison eiter active or non active positi... 8081f4b
renovate[bot] pushed 1 commit to renovate-all-gradle-minor-patch ministryofjustice/prison-register
- Update all non major Gradle dependencies f1ff77d
marcusaleman pushed 1 commit to MAP-1673-Add-endpoint-to-return-only-name-given-prison ministryofjustice/prison-register
- MAP-1673 test to return name or empty result paramatizared test for a given prison eiter active or non active positi... 681a44e
marcusaleman opened a pull request on ministryofjustice/prison-register
Map 1673 add endpoint to return only name given prison
marcusaleman pushed 1 commit to MAP-1673-Add-endpoint-to-return-only-name-given-prison ministryofjustice/prison-register
- MAP-1673 test to return only the name for a given prison eiter active or non active positive scenario 5ae8ea2
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison - Prison register
marcusaleman deleted a branch ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison - Prison register
marcusaleman deleted a branch ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison
marcusaleman created a branch on ministryofjustice/prison-register
MAP-1673-Add-endpoint-to-return-only-name-given-prison - Prison register
renovate[bot] pushed 1 commit to renovate-all-gradle-minor-patch ministryofjustice/prison-register
- Update all non major Gradle dependencies 690f71c
renovate[bot] pushed 1 commit to renovate-all-gradle-minor-patch ministryofjustice/prison-register
- Update all non major Gradle dependencies 988066d
renovate[bot] pushed 1 commit to renovate-all-gradle-minor-patch ministryofjustice/prison-register
- Update all non major Gradle dependencies 475764b
renovate[bot] opened a pull request on ministryofjustice/prison-register
Update all non major Gradle dependencies
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.fasterxml.jackson.datatype:jackson-datatype-jsr310](https://re...
renovate[bot] created a branch on ministryofjustice/prison-register
renovate-all-gradle-minor-patch - Prison register