Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-field-notes
https://github.com/microbiomedata/nmdc-field-notes/issues/209
pkalita-lbl opened an issue on microbiomedata/nmdc-field-notes
Replace variables named `template` with `templateName` where appropriate
This is a follow-on task identified in #208. There are many places scattered throughout the code where we have a variable named `template` that is typed with the `TemplateName` type. It was sugg...
pkalita-lbl closed an issue on microbiomedata/nmdc-field-notes
Account for changes to `packageName` field on backend
Part of the proposed changes for https://github.com/microbiomedata/nmdc-server/issues/1367 is changing the `packageName` field of a submission object from a string to an array of strings. This will...
pkalita-lbl pushed 7 commits to main microbiomedata/nmdc-field-notes
- Handle cases where submission's `packageName` field is either a string or array of strings 64277e0
- Use TemplateName type in place of arbitrary string 19d8830
- Show slot selector modal for all templates with no existing slot visibility selections f7879b1
- Do not show templates and slot modal if app metadata is not part of server data c411e9b
- Fix import formatting 516f117
- Apply suggestions from code review Co-authored-by: eecavanna <[email protected]> 37707cd
- Merge pull request #208 from microbiomedata/issue-177-multiple-environments Add support for multiple environmental t... 6617ea6
pkalita-lbl closed a pull request on microbiomedata/nmdc-field-notes
Add support for multiple environmental templates
Fixes #177 ### Summary These changes add support for selecting multiple environmental templates. This is enabled by backend support provided by https://github.com/microbiomedata/nmdc-server/...
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-field-notes
Yeah I like the idea. I started doing that and then realized that it would actually be _a lot_ of changes; enough that I'd be worried about breaking things. So I think I might save that as a follow...
eecavanna created a comment on a pull request on microbiomedata/nmdc-field-notes
In my local development environment, I failed to test this against the production `nmdc-server`. I ran into an issue during ORCID Login (unrelated to this branch). 
eecavanna created a review comment on a pull request on microbiomedata/nmdc-field-notes
After having read the rest of the diff, I would prefer the various `template` variables that contain template names, be named `templateName`; to distinguish them from the object stored in `TEMPLATE...
eecavanna created a review comment on a pull request on microbiomedata/nmdc-field-notes
This is a follow-up comment to the first one I left. This is the final file in the diff. After having reviewed the other files in the diff, I'd prefer `template` be named `templateName`. Given what...
eecavanna created a review comment on a pull request on microbiomedata/nmdc-field-notes
I felt confused when I first read this comment (reading it as "If the slot information of one of the templates is not visible..."). I find this alternative to be more clear: ```suggestion /...
eecavanna created a review on a pull request on microbiomedata/nmdc-field-notes
Thanks for implementing this, including coordinating the backend changes. I found the PR description very helpful in preparing my mind with relevant context for reviewing the diff. I'm comfortab...
eecavanna created a review comment on a pull request on microbiomedata/nmdc-field-notes
I think this alternative would be more instructive to other maintainers, but I am not sure it accurately represents the original author's intent. ```suggestion packageName: "", // TODO: CHANG...
eecavanna created a review comment on a pull request on microbiomedata/nmdc-field-notes
As I am reading this (before having read the remainder of the diff), I am wondering whether the author meant to write `template`—instead of `templates`—in the comment. _Edit: Nope! It's a refere...
eecavanna created a review on a pull request on microbiomedata/nmdc-field-notes
Thanks for implementing this, including coordinating the backend changes. I found the PR description very helpful in preparing my mind with relevant context for reviewing the diff. I'm comfortab...
pkalita-lbl pushed 1 commit to issue-177-multiple-environments microbiomedata/nmdc-field-notes
- Fix import formatting 516f117
pkalita-lbl opened a draft pull request on microbiomedata/nmdc-field-notes
Add support for multiple environmental templates
Fixes #177 ### Summary These changes add support for selecting multiple environmental templates. This is enabled by backend support provided by https://github.com/microbiomedata/nmdc-server/...
pkalita-lbl pushed 1 commit to issue-177-multiple-environments microbiomedata/nmdc-field-notes
- Do not show templates and slot modal if app metadata is not part of server data c411e9b
pkalita-lbl created a branch on microbiomedata/nmdc-field-notes
issue-177-multiple-environments - Mobile app for metadata collection on the go
pkalita-lbl pushed 18 commits to main microbiomedata/nmdc-field-notes
- Save slot visibility on submission server data instead of local settings 461cfaf
- Remove unused Store functions for handling hidden slots 88fc185
- Allow the slot selector modal to be launched automatically based on location state a98bb3b
- Standardize font sizes with new custom variables and global classes 8a069b3
- Use output of slot visibility curation in slot selector modal c7acb94
- Do not use schema slot grouping; use application-defined custom ordering e9a2383
- Store slot visibility info in TypeScript file instead of JSON; add stronger typing around template names 162c3de
- Rename slot visibilities file ecfb28f
- Clarify user-facing wording for occasionally used and uncommonly used slots 114b8a8
- Use previously defined TemplateName type fc0ab84
- Change function name to reflect usage 3864569
- Add TS const assertion to TEMPLATES 0c923b7
- Merge branch 'main' into issue-150-slot-visibility-per-study b56760a
- Add SlotName type as a semantic hint fabc44b
- Use ReactNode type for slot group description to support markup f0f8887
- Clarify comment 050d0cc
- Use consistent select/selected terminology afb2376
- Merge pull request #206 from microbiomedata/issue-150-slot-visibility-per-study Store slot visibility settings on a ... 236b84c
pkalita-lbl closed an issue on microbiomedata/nmdc-field-notes
Sharing custom field visibility options within a study
This is a feedback / user request coming from the GSC workshop, probably a low-priority feature request but I wanted to create an issue while still fresh in my mind :-). It seems like there is (a l...
pkalita-lbl closed a pull request on microbiomedata/nmdc-field-notes
Store slot visibility settings on a per-Study basis
Fixes #150 ### Summary Currently, slot visibility is stored as an app-level setting. This means that, for a given user, _all_ studies that use the soil template (for example) will show the s...
pkalita-lbl pushed 4 commits to issue-150-slot-visibility-per-study microbiomedata/nmdc-field-notes
pkalita-lbl created a review comment on a pull request on microbiomedata/nmdc-field-notes
I went with chosen here because even though the words visible and visibility are all over the code, they don't really appear much in the final interface. The text in the modal itself actually st...