Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints effectively. The class and module structures are well-organized, and the functionality works as expected. Keep up the excellen...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints as specified. The implementation is correct, and everything is structured well. Keep up the excellent work! If you want to fur...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Your code implementation is spot on! 🎉 You've met all the task requirements and constraints perfectly. Each class and function is well-structured and performs as expected. Keep up the great work, a...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Ensure that the `customers` parameter is a list of `Customer` instances and `cleaning_staff` is a list of `Cleaner` instances. This is crucial for the method to function correctly.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import statement is incorrect. `clean_hall` should be a method of the `Cleaner` class, not a standalone function. Remove this import and ensure you are calling the method on `Cleaner` instances.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import statement is incorrect. `watch_movie` should be a method of the `Customer` class, not a standalone function. Remove this import and ensure you are calling the method on `Customer` instan...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `movie_session` method call should be updated to correctly reference the instances of `Customer` and `Cleaner`. Ensure you are passing the correct instances.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Ensure that the `customer` parameter is indeed an instance of `Customer` before accessing `customer.name`. Consider adding a type check or documentation to clarify this requirement.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The main block is used for demonstration purposes and is not necessary for the class definition. Consider removing it if it's not required for testing or demonstration.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cinema_visit` function should create instances of `Customer`, `CinemaHall`, and `Cleaner` as per the task requirements. You need to instantiate these classes within the function.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import statement should use an absolute path as per the task requirements. Change it to `from app.cinema.bar import CinemaBar as cb`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import statement should use an absolute path as per the task requirements. Change it to `from app.cinema.hall import CinemaHall as ch`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The import statement for `Cleaner` is commented out and should use an absolute path. Uncomment and change it to `from app.people.cinema_staff import Cleaner`.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your submission! 🎉 While your code has been approved to help you move forward with your learning, there are several critical issues that need attention to ensure the functionality and...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `movie_session` method should call the `watch_movie` method on each `Customer` instance and the `clean_hall` method on each `Cleaner` instance. Replace `watch_movie(movie_name, customer)` with ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The imports should use absolute paths starting with 'app.' as per the task requirements. For example, `from app.bar import CinemaBar as cb` and `from app.hall import CinemaHall as ch`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `__init__` method is missing an underscore in its name. It should be `__init__` instead of `__init_`.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `Customer` class is not imported in this file. You need to import it to create a `Customer` instance. Consider adding `from app.people.customers import Customer` at the top of the file.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The function `cinema_visit` should create instances of `Customer`, `CinemaHall`, and `Cleaner` as specified in the task description. Currently, it directly uses the classes without creating instanc...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this pull request! 😊 However, there are a few critical issues that need to be addressed before we can approve it: 1. **Incorrect Import Statements**: The `main.py` ...
