Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaner` parameter should be of type `Cleaner`, not `str`. You should pass a `Cleaner` instance directly to the `cinema_visit` function, rather than creating a new `Cleaner` instance from a st...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job on implementing the solution! 🎉 The code is mostly well-structured and meets the task requirements. Here are some key points from the review: 1. **Cleaner Class**: The `Cleaner` class is...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
You are creating `Customer` instances twice for each customer. Consider reusing the `Customer` instances created earlier in the loop to avoid redundancy.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaner` parameter should be of type `Cleaner`, not `str`. Update the parameter type and adjust the function call accordingly.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Since `cleaning_staff` is expected to be a single `Cleaner` instance, you should call `clean_hall` directly on `cleaning_staff` without iterating over it.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaning_staff` parameter should be a single `Cleaner` instance, not a list. Update the parameter type and usage accordingly.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve the pull request. Specifically, the `cleaning_staff` parameter should...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Instead of appending a string directly, you should call the `watch_movie` method on each `Customer` instance as per the task description: 'calls customers method `watch_movie`'.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Instead of directly appending a string, create a `Customer` instance and use the `CinemaBar.sell_product` method to simulate selling a product to the customer.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
Instead of appending a string directly, you should call the `clean_hall` method on the `Cleaner` instance as per the task description: 'calls cleaner method `clean_hall`'.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The logic here should involve creating a `CinemaHall` instance and using its `movie_session` method to handle the movie session, which includes customers watching the movie and the cleaner cleaning...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! 😊 While you've made great progress, there are a few critical issues that need to be addressed to fully meet the task requirements. Specifically, the `C...
ProgrammerYaroslav closed a pull request on mate-academy/py-cinema-visit
Test
Run actions/checkout@v2 Syncing repository: mate-academy/py-cinema-visit Getting Git version info Temporarily overriding HOME='/home/runner/work/_temp/5d672167-52f7-4ceb-b2dd-dc072bb017f5' b...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your implementation meets all the task requirements and constraints perfectly. Each class and method is well-defined, and your code is clean and organized. Keep up the excellent work! ...
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `cleaner` parameter should be a string representing the cleaner's name, not a `Cleaner` instance. Update the type hint to `str` to reflect the correct input type as per the task description.
mateacademy-ai-mentor created a review comment on a pull request on mate-academy/py-cinema-visit
The `customers` parameter should be a list of dictionaries, not a `Customer` instance. Update the type hint to `List[Dict[str, str]]` to reflect the correct input type as per the task description.
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Thank you for your hard work on this project! 😊 However, there are a few critical issues that need to be addressed before we can approve the pull request: 1. **Incorrect Parameter Types**: The `ci...
mateacademy-ai-mentor created a review on a pull request on mate-academy/py-cinema-visit
Great job! 🎉 Your code meets all the task requirements and constraints perfectly. Each class and function is implemented correctly, and everything works as expected. Keep up the excellent work and ...
