Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
thomashampson opened a draft pull request on mantidproject/mantid
Keep most recent successful nightly
### Description of work #### Summary of work <!-- Please provide a short, high level description of the work that was done. --> <!-- Why has this work been done? If there is no linked issue...
thomashampson pushed 1 commit to 38147_keep_most_recent_successful_nightly mantidproject/mantid
- Only un-keep builds that were automatically kept 99da645
thomashampson pushed 1 commit to 38147_keep_most_recent_successful_nightly mantidproject/mantid
- Only un-keep builds that were automatically kept c2de9ee
rbauststfc created a review on a pull request on mantidproject/mantid
I've followed the manual testing steps since all changes have been made and everything's working well. All PR comments have been addressed, either by myself or Jonathan, and we've both approved eac...
robertapplin pushed 1 commit to 0-wild-imports2 mantidproject/mantid
- Fix wild import warnings in system tests d276f82
rboston628 created a branch on mantidproject/mantid
ewm7509-property-value - Main repository for Mantid code
thomashampson pushed 2 commits to 38147_keep_most_recent_successful_nightly mantidproject/mantid
robertapplin pushed 1 commit to 0-wild-imports2 mantidproject/mantid
- Fix wild import warnings in system tests 8861379
jhaigh0 pushed 1 commit to 38008_baselinefittingpresenter_changes mantidproject/mantid
- use unique pointer to baselinefitting presenter in the alc interface 61fbf83
robertapplin created a review comment on a pull request on mantidproject/mantid
If you are happy to do it in this PR then yes please!
thomashampson pushed 3 commits to 38103_logic_groupingtabwidgetview mantidproject/mantid
- Complete the test coverage of check_and_get_filename Co-authored-by: Mohammed Almakki <[email protected]> ... 5186225
- Refactor tests to avoid duplicate code 9fd3edd
- Fix test after refactor c0da6c7
jhaigh0 created a comment on a pull request on mantidproject/mantid
Happy with the changes made in the latest commit that move the threading operations to the model 👍
rbauststfc created a review comment on a pull request on mantidproject/mantid
Thanks @robertapplin, I've had a go at doing that. I think you could probably open an issue to look at adding a bit more test coverage to the new model, but hopefully this will do for now. @jhai...
rbauststfc pushed 1 commit to 38104_PhaseTablePresenter_cleanup mantidproject/mantid
- Move performing calculations on a thread to model Move the code that runs the phasequad and phase table calculations... f0dc327
jhaigh0 pushed 4 commits to 38008_baselinefittingpresenter_changes mantidproject/mantid
jhaigh0 created a review comment on a pull request on mantidproject/mantid
Would you like that changed for this pr? or is this just a comment.
GuiMacielPereira created a review on a pull request on mantidproject/mantid
I have just followed the instructions on https://developer.mantidproject.org/Testing/MuonAnalysis_test_guides/Muon_ALC.html and I think there is an issue after I press fit. The fit shows as success...
robertapplin created a review comment on a pull request on mantidproject/mantid
This might be an accidental change?
robertapplin created a review comment on a pull request on mantidproject/mantid
It looks like this is covered by line 278 to 280 for this file where it calls `updatePeakData` after doing `setCorrectedData`
robertapplin created a review comment on a pull request on mantidproject/mantid
Ideally we want to subscribe an `IALCBaselineModellingPresenter` (an interface class presenter) to the view. This would give extra flexibility in the future if we wanted to create another Presenter...
robertapplin created a review comment on a pull request on mantidproject/mantid
The old code seems to use an owning raw pointer for the presenter! It would be great to use a `std::unique_ptr` for the presenter so we do not need to worry about managing its lifetime
robertapplin created a review comment on a pull request on mantidproject/mantid
Can these methods be `const` methods?
robertapplin created a review on a pull request on mantidproject/mantid
These changes are looking really good! Its a vast improvement to the code from what it was previously! I have spotted a few extra improvements we could make