Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
robertapplin created a review on a pull request on mantidproject/mantid
These changes are looking really good! Its a vast improvement to the code from what it was previously! I have spotted a few extra improvements we could make
GuiMacielPereira pushed 3 commits to alcdataloadingpresenter-qobject mantidproject/mantid
- Add subscribePresenter method Add method to allow view to store a pointer to presenter 8376bb6
- Put presenter calls inside view slots Instead of the previous calls: view -> emit signal -> presenter catches signal... e55c1a7
- Replace signal by calling presenter directly Option to toggle auto add would trigger a signal that would call the fu... 06af59b
robertapplin created a review comment on a pull request on mantidproject/mantid
I think Rachel's idea sounds good, to pass the callback methods through to the model, assuming its simple enough to do this. But if its a lot of work, then its not so bad to keep it the same
thomashampson created a comment on a pull request on mantidproject/mantid
Marking this as draft while I fix the tests
mantid-builder pushed 5 commits to ornl-next mantidproject/mantid
github-actions[bot] closed an issue on mantidproject/mantid
Incorrect incident energies calculated for MERLIN in PyChop
**Original reporter:** David Voneshen at ISIS **Describe the bug** The incident energies are not calculated correctly for MERLIN after changing the frequency. **To Reproduce** For example...
mantid-builder pushed 5 commits to main mantidproject/mantid
thomashampson closed a pull request on mantidproject/mantid
Fix for incorrect incident energies for Merlin in PyChop
### Description of work #### Summary of work When PyChop is used in normal user mode instead of instrument scientist mode, the default value for the chopper phase has to be used. The default va...
GuiMacielPereira created a review comment on a pull request on mantidproject/mantid
I am a bit confused by how you can delete this line without somehow calling `updatePeakData()` inside of `setCorrectedData()` in the presenter. Before, when the model would call `setCorrectedData()...
jhaigh0 created a review comment on a pull request on mantidproject/mantid
@robertapplin what do you think?
rbauststfc created a review comment on a pull request on mantidproject/mantid
Yes, I guess I was thinking that technically you might be able to pass the callback methods through to the model in the same way that they're currently being passed to a method on the calculation t...
jhaigh0 pushed 1 commit to 38008_baselinefittingpresenter_changes mantidproject/mantid
- fix cppcheck shadow variable ff25b71
jhaigh0 pushed 1 commit to 38104_PhaseTablePresenter_cleanup mantidproject/mantid
- pr suggested changes 1f29f6a
jhaigh0 created a review comment on a pull request on mantidproject/mantid
I think I left it there so it would be able to easily add the `self.handle_phase_table_calculation*` methods.
jhaigh0 pushed 1 commit to 38008_baselinefittingpresenter_changes mantidproject/mantid
- remove qobject dependency from baselinemodelling model and presenter 7fb4570
jhaigh0 opened a pull request on mantidproject/mantid
Remove qobject dependency from baselinemodelling model and presenter
### Description of work Remove qobject inheritance from the `IALCBaselineModellingModel` and `ALCBaselineModellingPresenter`. Needed to move quite a number of things around so that connections ...
jhaigh0 created a branch on mantidproject/mantid
38008_baselinefittingpresenter_changes - Main repository for Mantid code
robertapplin created a review on a pull request on mantidproject/mantid
I can confirm the resolution plots are the same in normal user mode and in instrument scientist mode. I checked with Silke that a test cannot be added for this code because the functions are huge, ...
SilkeSchomann pushed 1 commit to 38182_phase_fix_pychop mantidproject/mantid
- Pass chopper number into _get_phase 3a0e7d9
thomashampson created a review comment on a pull request on mantidproject/mantid
Since the only use of `key` in this function is `key[7]`, please can we just pass the int to the function, and give it a meaningful variable name? That would help a lot to clarify what it is.