Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
4lejandrito created a review comment on a pull request on liferay-headless/liferay-portal
I did it inline to avoid shifting all the code to the left. A classic `buy space` from Brian.
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
CI is automatically triggering the following test suites: - ci:test:**sf**
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>playwright</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tr...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<html><h3>:x: ci:test:headless-staging - 238 out of 252 jobs passed in 3 hours 12 minutes</h3><details><summary>Click here for more details.</summary><br/><p>This pull is eligible for <a href="http...
ccorreagg created a review comment on a pull request on liferay-headless/liferay-portal
I just made the test locally by using both methods and at least in my case, both prints the whole stack trace. I guess the method with the message + throwable is available to print, one the one han...
liferay-headless pushed 31 commits to master liferay-headless/liferay-portal
- LPD-39547 Remove NullConvertibleEntryTest#testGetNullConvertibleEntries This test was created to follow test plan ou... eaf041b
- LPD-39547 Remove getNullConvertibleEntries method, no more usage 8ea380a
- LPD-39547 Auto, gw buildService fb862e3
- LPD-39547 Assert that null name value gets converted to blank string "" 7a2b774
- LPD-39547 Use try finally to ensure that null entry is cleaned up for testFetchNullConvertibleEntry 9324a61
- LPD-39547 SF 00b9357
- LPD-39411 Switch current and available locales sides and the box height in site settings so it matches the style in i... 63dbfa9
- LPD-40151 Uses correct component names b1b23ed
- LPD-39599 - fixed PortletConfigurationPermissionsPage.ts 6404c9d
- LPD-39562 Use LinkedHashMap to keep the original order d1df19a
- LPD-39562 buildREST 0f26650
- LPD-39562 Include it in the same request. As now the schema is inside the JSON before the endpoint, everything is cre... 3739ec9
- LPD-39562 prep next 8d15033
- LPD-39562 prep next 39c1122
- LPD-39945 Remove descriptions that don't exist anymore 90536da
- LPD-38030 Encode the path used for the default landing page to allow for multibyte characters in the friendly URL 5c55d19
- LPD-38030 Integration test 86aa9a1
- LPD-38030 SF 30e0f2b
- LPD-37782 Deep copy configuration modified by CX. Assignment or shallow copy results in transformed config leaking to... 883313e
- LPD-37782 Add `onReady` callback, that triggers at the very end of editor initialization aefdd2d
- and 11 more ...
ccorreagg created a review on a pull request on liferay-headless/liferay-portal
Some work to still do
ccorreagg closed a draft pull request on liferay-headless/liferay-portal
LPD-39219 Include the many to one object field as a possible one
Related ticket: https://liferay.atlassian.net/browse/LPD-39219
ccorreagg created a comment on a pull request on liferay-headless/liferay-portal
The buildREST commit does not contain the changes in the headless-commerce-delivery-order-api module. Please, review the commit message contains all the breaking changes
dnebing created a review comment on a pull request on liferay-headless/liferay-portal
Sure, but the implementation is the first logs msg.toString() while the second logs throwable.getMessage(). Either way, getting the stack trace is important for debugging purposes.
ccorreagg created a comment on a pull request on liferay-headless/liferay-portal
@movaldivia It seems it could be related with your changes. I have executed REST Builder in the `modules/apps/commerce/headless/headless-commerce/headless-commerce-delivery-cart-impl` folder and...
liferay-headless pushed 1 commit to master liferay-headless/liferay-portal
- LPS-77699 Update Translations d8f929a
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-25.liferay.com/job/test-portal-acceptance-pullrequest(master)/6174/">test-portal-acceptance-pullrequest(master)#6174</a...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<html><h3>:x: ci:test:relevant - 0 out of 1 jobs passed in 24 minutes</h3><details><summary>Click here for more details.</summary><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/li...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>playwright</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tr...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>relevant</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>relevant</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>headless-playwright</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<html><h3>:x: ci:test:playwright - 0 out of 1 jobs passed in 57 seconds</h3><details><summary>Click here for more details.</summary><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>playwright</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tr...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>headless-staging</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-por...
ccorreagg created a review comment on a pull request on liferay-headless/liferay-portal
But I see two methods with a similar header: public void error(Object msg); public void error(Throwable throwable); Maybe it was just a matter of which one was being used by Java?
dnebing created a review comment on a pull request on liferay-headless/liferay-portal
The first form includes the stack trace; the second will only log the message. The first form is preferred IMHO.