Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
DaniSzimko created a comment on a pull request on liferay-headless/liferay-portal
Closing this, because https://github.com/liferay-content-management/liferay-portal/pull/6031 will fix the issue.
ccorreagg created a review comment on a pull request on liferay-headless/liferay-portal
What about testing it? Is it possible? I miss the tests :cry:
ccorreagg created a review comment on a pull request on liferay-headless/liferay-portal
Could we do it inline? I am not sure about creating this method
ccorreagg created a review comment on a pull request on liferay-headless/liferay-portal
Which is the difference between `_log.error(throwable, throwable);` and `_log.error(throwable);`. I have seen both patterns. Just to decide which one we want to leave
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-5.liferay.com/job/test-portal-source-format/6528/">test-portal-source-format#6528</a><br/></div><div><strong>Jenkins Re...
ccorreagg created a comment on a pull request on liferay-headless/liferay-portal
And remember to update the first commit message, the LPD is not correct
ccorreagg created a comment on a pull request on liferay-headless/liferay-portal
Hey @magjed4289 , I have included a couple of commits to fix the bad tear down process of the Headless Builder tests. Please, could you update the rest of them?
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-7.liferay.com/job/test-portal-source-format/6281/">test-portal-source-format#6281</a><br/></div><div><strong>Jenkins Re...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<html><h3>:heavy_check_mark: ci:test:sf - 1 out of 1 jobs passed in 6 minutes</h3><details><summary>Click here for more details.</summary><h4>Base Branch:</h4><p>Branch Name: <a href="https://githu...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<html><h3>:heavy_check_mark: ci:test:sf - 1 out of 1 jobs passed in 5 minutes</h3><details><summary>Click here for more details.</summary><h4>Base Branch:</h4><p>Branch Name: <a href="https://githu...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>sf</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree/maste...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>sf</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree/maste...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
Pull request has been successfully forwarded to https://github.com/brianchandotcom/liferay-portal/pull/155524 [Console](https://test-1-3.liferay.com/job/forward-pullrequest/698//consoleFull)
liferay-continuous-integration closed a pull request on liferay-headless/liferay-portal
LPD-39489 - Investigate failure in LocalFile.StagingUsecase#ActivateStagingForSiteWithTheme
Navigate back to Guest home page after deprecated flag settings [JIRA ticket](https://liferay.atlassian.net/browse/LPD-39489)
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
All required test suite(s) passed. Forwarding pull request to `brianchandotcom`. [Console](https://test-1-3.liferay.com/job/forward-pullrequest/698//consoleFull)
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-8.liferay.com/job/test-portal-source-format/7296/">test-portal-source-format#7296</a><br/></div><div><strong>Jenkins Re...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
CI is automatically triggering the following test suites: - ci:test:**sf**
magjed4289 created a comment on a pull request on liferay-headless/liferay-portal
ci:test:headless-playwright
DaniSzimko created a comment on a pull request on liferay-headless/liferay-portal
ci:test:headless-staging
DaniSzimko created a comment on a pull request on liferay-headless/liferay-portal
Hello @Mikellorza , I reviewed the code and ran the integration tests. Everything looks good to me.
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>sf</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree/maste...
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
Skipping previously passed test suites: - `ci:test:relevant` - `ci:test:sf` - `ci:test:stable`
liferay-continuous-integration created a comment on a pull request on liferay-headless/liferay-portal
CI is automatically triggering the following test suites: - ci:test:**relevant** - ci:test:**sf** - ci:test:**stable** The p...