Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
rijema opened a pull request on liferay-bpm/liferay-portal
LPD-39807
Task 1 for https://liferay.atlassian.net/browse/LPD-39807
rebsilva created a review on a pull request on liferay-bpm/liferay-portal
LGTM! :tada: just to confirm @igor-franca, at some point we need to return to the code that was reverted right? it would be the case to create a task so we can prioritize inside the team?
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
Pull request has been successfully forwarded to https://github.com/brianchandotcom/liferay-portal/pull/155473 [Console](https://test-1-27.liferay.com/job/forward-pullrequest/1431//consoleFull)
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
All required test suite(s) completed. Forwarding pull request to `brianchandotcom`. [Console](https://test-1-27.liferay.com/job/forward-pullrequest/1431//consoleFull)
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
Skipping previously completed test suites: - `ci:test:relevant` - `ci:test:sf` AND Skipping previously passed test suites: - `ci:test:stable`
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
CI is automatically triggering the following test suites: - ci:test:**relevant** - ci:test:**sf** - ci:test:**stable** The p...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-32.liferay.com/job/test-portal-source-format/9223/">test-portal-source-format#9223</a><br/></div><div><strong>Jenkins R...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running <code>generate testray csv</code> for testrayBuildID: <b>48871923</b>.</p><p>Job Link: <a href="https://test-1-27.liferay.com/job/generate-tes...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<h1>Build started.</h1><p>Jenkins is currently running tests in the <code>sf</code> test suite.</p><h4>Base Branch:</h4><p>Branch Name: <a href="https://github.com/liferay/liferay-portal/tree/maste...
rebsilva created a review comment on a pull request on liferay-bpm/liferay-portal
yes, you are right! i will add this case as well, thanks!
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-27.liferay.com/job/test-portal-acceptance-pullrequest(master)/12867/">test-portal-acceptance-pullrequest(master)#12867<...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<html><h3>:x: ci:test:workflow - 363 out of 390 jobs passed in 1 hour 47 minutes</h3><details><summary>Click here for more details.</summary><br/><p>This pull is eligible for <a href="https://grow....
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-29.liferay.com/job/test-portal-acceptance-pullrequest(master)/10564/">test-portal-acceptance-pullrequest(master)#10564<...
liferay-continuous-integration closed a pull request on liferay-bpm/liferay-portal
[Fire LPP-56152] LPD-39828
[LPP-56152](https://liferay.atlassian.net/browse/LPP-56152) [LPD-39828](https://liferay.atlassian.net/browse/LPD-39828) Reason why I am resending: https://github.com/brianchandotcom/liferay-por...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
All required test suite(s) passed. Forwarding pull request to `brianchandotcom`. [Console](https://test-1-29.liferay.com/job/test-portal-acceptance-pullrequest(master)/10564//consoleFull)
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<html><h3>:heavy_check_mark: ci:test:stable - 24 out of 24 jobs passed</h3><h3>:heavy_check_mark: ci:test:relevant - 31 out of 31 jobs passed in 1 hour 5 minutes</h3><details><summary>Click here fo...
cgmonte created a review comment on a pull request on liferay-bpm/liferay-portal
You should cover both 'Following Events' and also 'Entire Series' case. Can you update the test to do it so?
cgmonte created a review comment on a pull request on liferay-bpm/liferay-portal
Add daysFromNow to the function signature: ``` async fillEventWithRecurrenceUntilDate(daysFromNow: number) ```
cgmonte created a review comment on a pull request on liferay-bpm/liferay-portal
pass `daysFromNow` here
cgmonte created a review comment on a pull request on liferay-bpm/liferay-portal
Parametrize this value, like: ``` async addRecurrenceUntilDate(daysFromNow: number) { const nowDate = new Date(); const fiveDaysFromNowDate = new Date( nowDate.getFullYear(), n...
cgmonte created a review on a pull request on liferay-bpm/liferay-portal
Solution looks good to me, but the test can be improved. Please take a look at my comment. Let me know if you need anything. Thanks!
cgmonte created a review on a pull request on liferay-bpm/liferay-portal
Solution looks good to me, but the test can be improved. Please take a look at my comment. Let me know if you need anything. Thanks!
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-32.liferay.com/job/test-portal-acceptance-pullrequest(master)/5387/">test-portal-acceptance-pullrequest(master)#5387</a...
liferay-continuous-integration created a comment on a pull request on liferay-bpm/liferay-portal
<div><div><strong>Jenkins Build:</strong><span></span><a href="https://test-1-27.liferay.com/job/test-portal-acceptance-pullrequest(master)/12866/">test-portal-acceptance-pullrequest(master)#12866<...