Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

impresso/impresso-middle-layer

theorm created a review comment on a pull request on impresso/impresso-middle-layer
I suspect this should be locked down only to users belonging to a certain group - those who are allowed to review and approve.

View on GitHub

theorm created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

theorm created a review comment on a pull request on impresso/impresso-middle-layer
If it's a public API service - it needs a schema, otherwise it will be hanging in Swagger misleading users.

View on GitHub

theorm created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

theorm created a review comment on a pull request on impresso/impresso-middle-layer
I'd suggest using Sequelize' [recommended way of working with models](https://sequelize.org/docs/v6/other-topics/typescript/#usage) in Typescript. It's slightly different but much cleaner type-wise.

View on GitHub

theorm created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

theorm created a review comment on a pull request on impresso/impresso-middle-layer
What's an obfuscated user for?

View on GitHub

theorm created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

theorm created a review comment on a pull request on impresso/impresso-middle-layer
[Here](https://github.com/impresso/impresso-middle-layer/pull/419/files#diff-d40228c94ec34f9469d59441e60c0b9b54b6a5be0953f01752e758b9489e16a0R98) it's still read as `userGroups`. Better leave the p...

View on GitHub

theorm created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

danieleguido pushed 3 commits to feature/user-bitmap impresso/impresso-middle-layer
  • Redact response objects in public API (#439) * fixed json schema errors and added recatction method * added redac... 2fd0647
  • fixed schema definitions (#440) bbebf2c
  • Merge branch 'develop' into feature/user-bitmap d93c8b4

View on GitHub

danieleguido pushed 2 commits to feature/user-bitmap impresso/impresso-middle-layer
  • fix typescript for celery client to get the `get()`method on AsyncResult cbf38ec
  • remove unused getUpToDateBitmap - we do this using Celery 92ab7a9

View on GitHub

theorm created a tag on impresso/impresso-middle-layer

v3.0.3 - Middle layer API

theorm published a release on impresso/impresso-middle-layer
v3.0.3
theorm pushed 3 commits to master impresso/impresso-middle-layer
  • Redact response objects in public API (#439) * fixed json schema errors and added recatction method * added redac... 2fd0647
  • fixed schema definitions (#440) bbebf2c
  • Merge pull request #441 from impresso/develop Release v3.0.3 b8d64a3

View on GitHub

theorm closed a pull request on impresso/impresso-middle-layer
Release v3.0.3
* Response redaction in Public API
theorm opened a pull request on impresso/impresso-middle-layer
Release v3.0.3
* Response redaction in Public API
theorm deleted a branch impresso/impresso-middle-layer

chore/schema-update-oneOf

theorm pushed 1 commit to develop impresso/impresso-middle-layer
  • fixed schema definitions (#440) bbebf2c

View on GitHub

theorm closed a pull request on impresso/impresso-middle-layer
[chore] fixed schema definitions
`$oneOf` (incorrect) -> `oneOf` (correct)
theorm opened a pull request on impresso/impresso-middle-layer
[chore] fixed schema definitions
`$oneOf` (incorrect) -> `oneOf` (correct)
theorm created a branch on impresso/impresso-middle-layer

chore/schema-update-oneOf - Middle layer API

danieleguido pushed 1 commit to develop impresso/impresso-middle-layer
  • Redact response objects in public API (#439) * fixed json schema errors and added recatction method * added redac... 2fd0647

View on GitHub

danieleguido created a review on a pull request on impresso/impresso-middle-layer

View on GitHub

theorm pushed 1 commit to feature/redact-objects impresso/impresso-middle-layer

View on GitHub

theorm opened a pull request on impresso/impresso-middle-layer
Redact response objects in public API
Code to redact selected responses under certain conditions. Redactions follow a policy. One policy per response schema. Condition for redaction at the moment is set to: "running as public API" and ...
theorm pushed 1 commit to feature/redact-objects impresso/impresso-middle-layer
  • added redaction hook and applied it to a number of public endpoints c2b1463

View on GitHub

theorm created a branch on impresso/impresso-middle-layer

feature/redact-objects - Middle layer API

theorm opened an issue on impresso/impresso-middle-layer
Review all public endpoint to make sure none of them return collections ids
TR passages endpoint returns all collections.
danieleguido pushed 2 commits to feature/user-bitmap impresso/impresso-middle-layer
  • add default for account detail creation (user bitmap mostly) d81498b
  • refine servie user request 7678274

View on GitHub

Load more