Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
danielmaltz1 created a review comment on a pull request on hmrc/income-tax-view-change-frontend
I think at the moment subtransactiontype can only be Nics2, Accepted or Rejected. I'm not familiar with the logic behind this, would adding Poa1 and Poa2 interfere with any of that?
avelx created a comment on a pull request on hmrc/income-tax-view-change-frontend
@danielmaltz1 - there are few comments on the PR if you can have a look pls, technically things are fine
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
if we can cross check with BAs that we can use absolute value here? as I would expect this to be reflected in the requirements
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
seem to me a change in logic, are you sure we need to use absolute value on this occasion? might be something to cross check with BAs
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
I think we can merge this into a single property on the view model level?
mywyau pushed 1 commit to MISUV-8615 hmrc/income-tax-view-change-frontend
- refactor view model 471c199
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
as per comment above, please make passing params values more readable
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
"1" and "2" would be a magic numbers, I guess it will be hard to support this code in the future, maybe we can pass subTransactionType on this occasion if you like to optimise this part of the code
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
more refactoring to be done as a part of : https://jira.tools.tax.service.gov.uk/browse/MISUV-8654
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
next story created as tech debt feel free to comment: https://jira.tools.tax.service.gov.uk/browse/MISUV-8654
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
if we can add comment somewhere that these are transactionCode (?)