Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
mywyau pushed 1 commit to MISUV-8369_add_txm_auditing_event_to_OptOut_quarterly hmrc/income-tax-view-change-frontend
- revert logback-test 4fd0472
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
I would suggest to stick to the smaller changes a possible and avoid changes in other areas, thats fine to create other stories along the way (tech debt etc) when you work on the story; we just nee...
mywyau created a review comment on a pull request on hmrc/income-tax-view-change-frontend
he's off for three weeks starting this week, prior to that his last comment was to add a test for checking if the audit triggers for showing error page scenario. He reviewed it prior and I told him...
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
totally agree, its a good idea, but we if we can move this under different story, so to have as small PRs a possible; but again, check with your TL pls for other comments
mywyau created a review comment on a pull request on hmrc/income-tax-view-change-frontend
clean up of the naming similar named files causing issues when juggling changes and investigating issues, and differentiating between the two component specbases, can differentiate between the two ...
platops-pr-bot created a comment on a pull request on hmrc/income-tax-view-change-frontend
- Routes defined in [conf/testOnlyDoNotUseInAppConf.routes](https://github.com/hmrc/income-tax-view-change-frontend/blob/8479-fix/conf/testOnlyDoNotUseInAppConf.routes#L33) should contain `/test-on...
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
absolutely fine, move these to tech debt story and reduce scope of the current changes to control change / simplify testing, as unlikely you would test all these in the current sprint; you can addr...
mywyau created a review comment on a pull request on hmrc/income-tax-view-change-frontend
it's mostly a clean up of build.sbt lots of repeated option or something from what I remember, and we can likely move out the dependencies and coverage into it's own object to help keep the file sm...
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
this is fine to do these changes (rename this triat), but again, these to be done agreed if we need these between both teams; as other team member would expect fine things were their are; this is q...
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
same approach as above;
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
as above, if we can have a separate story for these changes this must be discussed/agreed on the TLs level what and why we are doing these;
avelx created a review comment on a pull request on hmrc/income-tax-view-change-frontend
If we can kindly bundle any library upgrade into a separate story to have some level of control where we are heading etc;
mywyau pushed 1 commit to MISUV-8369_add_txm_auditing_event_to_OptOut_quarterly hmrc/income-tax-view-change-frontend
- fix ispec due to use of tick naming convention b297fdf
danielmaltz1 created a review comment on a pull request on hmrc/income-tax-view-change-frontend
[MISUV-8655](https://jira.tools.tax.service.gov.uk/browse/MISUV-8655)
