Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ewbankkit closed a pull request on hashicorp/terraform-provider-aws
r/sagemaker_hub - new resource
<!--- See what makes a good Pull Request at: https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/ ---> ### Description <!--- Please provide a helpful description of what chang...
ewbankkit created a review comment on a pull request on hashicorp/terraform-provider-aws
```console % make testacc TESTARGS='-run=TestAccBatchJobDefinition_updateWithTags' PKG=batch make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... ...
ewbankkit pushed 2 commits to b-aws_batch_job_definition-new-revision-with-tags hashicorp/terraform-provider-aws
ewbankkit created a review comment on a pull request on hashicorp/terraform-provider-aws
I'm going to keep because if only `tags` change then we _do_ want to call `UpdateTags`.
justinretzolk created a comment on an issue on hashicorp/terraform-provider-aws
Hey @EugenKon 👋 Any of the canned ACLs listed in the [AWS documentation](https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html) should work. Do you think a resolution to this woul...
justinretzolk created a comment on an issue on hashicorp/terraform-provider-aws
Hey @av-edgsle 👋 Thank you for taking the time to raise this! While we try not to break compatibility with AWS-compatible services, it's not something that we're able to effectively test, and so we...
github-actions[bot] created a comment on an issue on hashicorp/terraform-provider-aws
# Community Note **Voting for Prioritization** * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the ...
justinretzolk created a comment on an issue on hashicorp/terraform-provider-aws
Hey @laserpedro 👋 Thank you for taking the time to raise this! It looks like this has come up before in #16452, where a couple of workarounds were offered. Can you review that report (and/or the PR...
lapkritinis created a comment on an issue on hashicorp/terraform-provider-aws
Constructive discussion. What is the intent of this new resource? To detach policies which should not be attached to? In that case fine, but it should not replace manage_policies_arns in my opinion...
github-actions[bot] created a comment on an issue on hashicorp/terraform-provider-aws
> [!WARNING] > This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them. > > Ongoing conversations amongst...
justinretzolk created a comment on an issue on hashicorp/terraform-provider-aws
My findings were the same as @eugercek mentioned above. Looking at the API reference for [`StartQueryExecution`](https://docs.aws.amazon.com/athena/latest/APIReference/API_StartQueryExecution.html)...
justinretzolk closed an issue on hashicorp/terraform-provider-aws
[Bug]: creating aws_athena_database resource requires seemingly unnecessary permissions
### Terraform Core Version 1.9.7 ### AWS Provider Version 5.71.0 ### Affected Resource(s) aws_athena_database ### Expected Behavior I'd like to be able to create this resource,...
gdavison created a review comment on a pull request on hashicorp/terraform-provider-aws
Because the create, read, and update operations all have a `Tags` field, the `identifierAttribute` can be removed from the `// @Tags` annotation. This will remove an unnecessary tag update befor...
gdavison created a review comment on a pull request on hashicorp/terraform-provider-aws
The two config functions could be combined into a single function that takes a second parameter. I would clarify the intent and make the change more obvious.
gdavison created a review on a pull request on hashicorp/terraform-provider-aws
A couple comments, otherwise looks good --- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (20.63s) --- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerPr...
gdavison created a review on a pull request on hashicorp/terraform-provider-aws
A couple comments, otherwise looks good --- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (20.63s) --- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerPr...
github-actions[bot] created a comment on an issue on hashicorp/terraform-provider-aws
> [!WARNING] > This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them. > > Ongoing conversations amongst...
cycleandsoak created a comment on an issue on hashicorp/terraform-provider-aws
Thanks for the quick response, @ewbankkit. It looks like AWS is returning a 400 when they should(?) be returning a 403. We don't have `lambda:TagResource` permission currently (it's denied by an or...
cycleandsoak closed an issue on hashicorp/terraform-provider-aws
[Bug]: aws_lambda_event_source_mapping fails with default tags in v5.70 in us-east-1 with dynamodb stream event source
### Terraform Core Version 1.9.3 ### AWS Provider Version 5.70.0 ### Affected Resource(s) * aws_lambda_event_source_mapping ### Expected Behavior The resource should create and...
ewbankkit pushed 1 commit to b-aws_batch_job_definition-new-revision-with-tags hashicorp/terraform-provider-aws
- Update job_definition_test.go e5b27c3
github-actions[bot] pushed 1 commit to gh-pages hashicorp/terraform-provider-aws
- Deployed 5ac4b2b0 with MkDocs version: 1.4.2 8edc587
ewbankkit pushed 3 commits to main hashicorp/terraform-provider-aws
- sagemaker apps log errors better Signed-off-by: drfaust92 <[email protected]> bcacbdd
- fmt Signed-off-by: drfaust92 <[email protected]> 8e62a90
- Merge pull request #39808 from DrFaust92/sagemaker-app-error r/sagemaker_app_image and image_version - log errors be... 5ac4b2b
ewbankkit closed a pull request on hashicorp/terraform-provider-aws
r/sagemaker_app_image and image_version - log errors better
<!--- See what makes a good Pull Request at: https://hashicorp.github.io/terraform-provider-aws/raising-a-pull-request/ ---> ### Description <!--- Please provide a helpful description of what chang...
ewbankkit created a comment on a pull request on hashicorp/terraform-provider-aws
@DrFaust92 Thanks for the contribution :tada: :clap:.
ewbankkit created a comment on a pull request on hashicorp/terraform-provider-aws
@DrFaust92 Thanks for the contribution :tada: :clap:.
ewbankkit created a review on a pull request on hashicorp/terraform-provider-aws
LGTM :rocket:. ```console % make testacc TESTARGS='-run=TestAccSageMakerHub_' PKG=sagemaker ACCTEST_PARALLELISM=3 make: Verifying source code with gofmt... ==> Checking that code complies wit...
justinretzolk created a comment on a pull request on hashicorp/terraform-provider-aws
Hey @YukiMichishita 👋 Thank you for taking the time to raise this! I may be missing something here, but this seems like a case where using [`replace_triggered_by`](https://developer.hashicorp.com/t...
justinretzolk created a comment on an issue on hashicorp/terraform-provider-aws
Linking to a relevant thread in the Terraform Core repo. Seems like this might be possible to implement as of very recently: https://github.com/hashicorp/terraform/issues/27310