Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
codingWithRach pushed 3 commits to main guardian/sIndicator
codingWithRach closed a pull request on guardian/sIndicator
Create unique add-on id
<!-- See https://github.com/guardian/recommendations/blob/main/pull-requests.md for recommendations on raising and reviewing pull requests. --> ## What does this change? As part of PR #1 I ha...
emdash-ie created a review comment on a pull request on guardian/sIndicator
I accidentally left a comment pending earlier that said: > To be clear, I don’t know what the impact of using a domain we don’t own is: maybe it’d be fine! But I worry that it’ll give the owner ...
codingWithRach created a review comment on a pull request on guardian/sIndicator
It's not case sensitive - so I've gone for [email protected]
codingWithRach pushed 1 commit to rachel/need-unique-add-on-id guardian/sIndicator
- Change to a domain we own! 4b94bab
emdash-ie created a review comment on a pull request on guardian/sIndicator
I’d be a little worried about using a domain we don’t own for this! Could we change it to guardian.co.uk? ```suggestion "id": "[email protected]", ``` …or change the name, may...
codingWithRach opened a pull request on guardian/sIndicator
Create unique add-on id
<!-- See https://github.com/guardian/recommendations/blob/main/pull-requests.md for recommendations on raising and reviewing pull requests. --> ## What does this change? As part of PR #1 I ha...
codingWithRach pushed 19 commits to main guardian/sIndicator
- Update lock files 9554908
- web-ext linting d2120d6
- Sign web extension in mozilla firefox 287a48b
- Correct location of options.html 128fe8d
- Add github workflow for building and signing the extension e38c24e
- Update version of upload-artifact 81818e7
- Corrections to workflow dc9c000
- Remove xpi files from github (now stored as workflow artifacts) ce81753
- Amend workflow afcd58a
- Change name of xpi and only build/sign when close PR 959027b
- Rename xpi and remove build/sign on merge (for now!) 3579010
- Update version number 77be0a7
- Reset version and build/sign on close 7d462a1
- Initial README c75c0b6
- Change version and when action runs 28fb975
- Update README 73486d2
- Correct spacing and add back icon credit 67cfba4
- Remove package-lock.json and display error if user tries to use npm a948cbf
- Merge pull request #1 from guardian/rachel/installation-process Create signed web extension for installation to Firefox 167dc5d
codingWithRach closed a pull request on guardian/sIndicator
Create signed web extension for installation to Firefox
<!-- See https://github.com/guardian/recommendations/blob/main/pull-requests.md for recommendations on raising and reviewing pull requests. --> ## What does this change? Uses [web-ext](https:...
codingWithRach pushed 2 commits to rachel/installation-process guardian/sIndicator
codingWithRach created a review comment on a pull request on guardian/sIndicator
I've removed `package-lock.json` and it now displays an error if the user attempts to use `npm` rather than `yarn`
codingWithRach created a comment on a pull request on guardian/sIndicator
> Looks good to me! Since we’re signing extensions on merge, we should make sure we’re the only ones who can merge PRs. Otherwise I’d be worried someone could open a PR with malicious changes and q...
codingWithRach created a review comment on a pull request on guardian/sIndicator
This change was a requirement of running `web-ext lint`, so we should probably adopt that rather than prettier, but good idea
codingWithRach created a review comment on a pull request on guardian/sIndicator
General confusion :-)
codingWithRach created a review comment on a pull request on guardian/sIndicator
Yes, I foolishly created the README as part of the PR, when it would have been much more sensible to create it in the repo, where the preview is a bit more helpful
emdash-ie created a review comment on a pull request on guardian/sIndicator
The changes in this file appear to be just formatting. Would it be worth adopting prettier in this repository in a subsequent PR?
emdash-ie created a review comment on a pull request on guardian/sIndicator
```suggestion You will need to update the version in `manifest.json` as part of your PR Repository secrets have been added for WEB_EXT_API_KEY and WEB_EXT_API_SECRET If these need to be upda...
emdash-ie created a review comment on a pull request on guardian/sIndicator
Markdown only adds a break between paragraphs when there’s a blank line, and I think this should probably be spaced like this: ```suggestion sIndicator is a web extension distributed individual...
emdash-ie created a review comment on a pull request on guardian/sIndicator
The spacing in this file is a bit inconsistent, and I don’t think the rendered result is quite what’s intended, mostly due to missing line breaks. I also think it’d be good to keep the icon cred...
emdash-ie created a review on a pull request on guardian/sIndicator
Looks good to me! Since we’re signing extensions on merge, we should make sure we’re the only ones who can merge PRs. Otherwise I’d be worried someone could open a PR with malicious changes and qui...
emdash-ie created a review on a pull request on guardian/sIndicator
Looks good to me! Since we’re signing extensions on merge, we should make sure we’re the only ones who can merge PRs. Otherwise I’d be worried someone could open a PR with malicious changes and qui...
codingWithRach pushed 1 commit to rachel/installation-process guardian/sIndicator
- Update README 73486d2