Message from Keith Randall:
Patch Set 2: Code-Review+2
---
Please don’t reply on this GitHub thread. Visit [golang.org/cl/622075](https://go-review.googlesource.com/c/go/+/622075#message-b0c6ac5c...
Message from Keith Randall:
Patch Set 6: Code-Review+2
---
Please don’t reply on this GitHub thread. Visit [golang.org/cl/620855](https://go-review.googlesource.com/c/go/+/620855#message-e8a1de32...
> I'll add a skip like #69593 and #69592. The fundamental issue is that I don't know how to express "it's a failure if there isn't at least one builder that can run this test, but it's ok if some b...
### Go version
go version devel go1.24-d0631b90a3 Wed Oct 23 04:48:55 2024 +0000 linux/amd64
### Output of `go env` in your module/workspace:
```shell
GO111MODULE=''
GOARCH='amd64'
GOAU...
### Proposal Details
Recently we have exposed the syscalls and types related to PTP (IEEE 1588) on Linux in the `unix` package.
Amongs those is a struct representing time in PTP calls, `unix.PtpC...
```
#!watchflakes
default <- pkg == "crypto/sha256" && test == "TestGolden/Armv8.0"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/87332735635...
```
#!watchflakes
default <- pkg == "crypto/sha256" && test == "TestGoldenMarshal/Armv8.0"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8733...
```
#!watchflakes
default <- pkg == "crypto/sha256" && test == "TestHash/SHA-224/Armv8.0"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/87332...
For html templates this project look already pretty good: [djLint](https://github.com/djlint/djLint).
For yaml templates (e.g. kubernetes helm) this seem like a open challenge to implement.
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/internal/gcimporter" && test == "TestIssue69912"
<details><summary>2024-10-24 15:50 x_tools-go1.22...
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "crypto/sha256" && test == "TestHash/SHA-224/Armv8.0"
<details><summary>2024-10-24 12:32 gotip-netbsd-arm64 go@77c53c1...
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "crypto/sha256" && test == "TestGoldenMarshal/Armv8.0"
<details><summary>2024-10-24 12:32 gotip-netbsd-arm64 go@77c53c...
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/internal/modindex" && test == "TestIncrementalNope"
<details><summary>2024-10-24 15:50 x_tools-go1...
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/internal/modindex" && test == "TestIncremental"
<details><summary>2024-10-24 15:50 x_tools-go1.22-...
Found new dashboard test flakes for:
#!watchflakes
default <- pkg == "golang.org/x/tools/cmd/stringer" && test ~ `TestEndToEnd`
<details><summary>2024-10-24 15:50 x_tools-gotip-solaris-am...
Are you able to estimate the the false positive rate when these cases are excluded? The file attached above contains the complete list of 1225 findings. Can you sample a couple of dozen?
> Personally I like the unbubbling idea, perhaps because I'm already a bit skeptical of the idea of bubbling in general. You could do it without increasing the size of chan by keeping a side table ...