Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
There were two comments here incorrectly marked as resolved, but I've deleted them to make it more obvious what the issue is since it was only made worse. 1. KDocs should not be touching the imp...
frigvid created a review comment on a pull request on frigvid/mob3000-group11
KDoc property shouldn't have a colon here, it'll likely render weirdly. It should be <property> <value>.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Incorrect creation KDoc property, and date does not follow ISO8601. Additionally, KDoc should have a short description of what it is.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
This is not resolved and the data class does not have proper indentation.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Unnecessary empty starting line in KDoc.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Unnecessary empty starting line in KDoc.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Dangling KDoc. Additionally, the parameter list and the class's opening bracket should be separated. The class property should also be indented.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
The if keyword, its parameter list and its opening bracket need to be separated. `if (` and `null) {`.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
The else keyword and its opening bracket need to be separated. `else {`.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
It is not about the actual result. It's about the line this comment is placed on. `Result<Unit>` is what the function returns to callers of the function, however, it does not extend or implement it...
Husseinabdulameer11 pushed 1 commit to userProfile_endringer frigvid/mob3000-group11
- Update ProfileEditRepository.kt bbe4cb2
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Unnecessary empty line in KDoc.
Husseinabdulameer11 pushed 1 commit to userProfile_endringer frigvid/mob3000-group11
- Update FriendsRepository.kt b00da73
frigvid created a review comment on a pull request on frigvid/mob3000-group11
It is literally the line I'm commenting on. The placement of something being implemented or extended, versus being an expected result is well defined. A class implementing `IProfileEditRepository` ...
frigvid created a review comment on a pull request on frigvid/mob3000-group11
`FriendRepository` does not expect `IFriendsRepository` as a result. It's implementing an interface and needs to be represented as such following Kotlin's style guide. It should be `) : IF`. Additi...