Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
This file has still not been removed, and it's been mentioned multiple times that this is not to be committed.
Husseinabdulameer11 pushed 1 commit to userProfile_endringer frigvid/mob3000-group11
- Delete app/release/baselineProfiles/1/app-release.dm d52c293
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Binaries are _still_ not removed. They've been mentioned multiple times, and are not to be committed.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Binaries are _still_ not removed. They've been mentioned multiple times, and are not to be committed.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Replacing the `Color.Red` with `MaterialTheme.colorScheme.`'s `error` or `onError` would be a nice touch. The color scheme parameter can simply be set to `Color.Red` for now.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
Are these meant to be static colors?
frigvid created a review comment on a pull request on frigvid/mob3000-group11
The last parameter in a parameter list should not have a trailing comma.
frigvid created a review comment on a pull request on frigvid/mob3000-group11
There should not be a comma in when using only a singular parameter. Should be `Text(text)`.
258030 created a review on a pull request on frigvid/mob3000-group11
Spacing issues seems to be mostly resolved. Altough getting gradle issues on OpeningMapperUnitTest.kt, have not tested this in master. EDIT: Getting the same issue in master
258030 created a review on a pull request on frigvid/mob3000-group11
Spacing issues seems to be mostly resolved. Altough getting gradle issues on OpeningMapperUnitTest.kt, have not tested this in master.
258030 created a review on a pull request on frigvid/mob3000-group11
Spacing issues seems to be mostly resolved. Code works
Husseinabdulameer11 pushed 1 commit to userProfile_endringer frigvid/mob3000-group11
- fixed some spacing and indentation issues 4a34bc4
258030 created a review comment on a pull request on frigvid/mob3000-group11
If we used invoke, yes It's messy to have similar/nearly identical usecases from the same repo in seperate classes, this solution does not make the application work any less inefficent and does no...
258030 created a review comment on a pull request on frigvid/mob3000-group11
Does the code work as intented? Are you saying this functionality does not do what it promises? This works the excact same way: `override suspend fun updateNews( newsId: String, ...
258030 created a review comment on a pull request on frigvid/mob3000-group11
Are you talking about KDoc or the actual functionality of the class? Can't see the same as you do
frigvid created a review on a pull request on frigvid/mob3000-group11
There are still a myriad of style issues that have not been fixed. These are not difficult, and shouldn't take more than 15~30 minutes to clean up. There are also unnecessary files still committ...
frigvid created a review on a pull request on frigvid/mob3000-group11
There are still a myriad of style issues that have not been fixed. These are not difficult, and shouldn't take more than 15~30 minutes to clean up. There are also unnecessary files still committ...