Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
kriswest created a comment on a pull request on finos/FDC3
> @robmoffat regarding the channel selector UI, there aren't white of black channels... The demo implementation is working fine for me. However, if I select the 'Default Web FDC3' UI in the demo I ...
kriswest created a comment on a pull request on finos/FDC3
@robmoffat regarding the channel selector UI, there aren't white of black channels... The demo implementation is working fine for me. However, if I select the 'Default Web FDC3' UI in the demo I do...
github-actions[bot] created a comment on a pull request on finos/FDC3
<img src="https://svg.test-summary.com/dashboard.svg?p=494&f=0&s=0" alt="494 passed">
github-actions[bot] created a comment on a pull request on finos/FDC3
<img src="https://svg.test-summary.com/dashboard.svg?p=494&f=0&s=0" alt="494 passed">
kriswest pushed 1 commit to fdc3-for-web-impl-getAgent-refactor finos/FDC3
- Revert dummy-desktop-agent to default directory 24d0bb2
kriswest pushed 1 commit to fdc3-for-web-impl-getAgent-refactor finos/FDC3
- Adding notes on non-standard error messages 5babe3c
kriswest created a review comment on a pull request on finos/FDC3
Actually, it is an OpenSource license, approved by the Open Source Initiative - the categorizations they display are within the set of Open Source licenses and are: 
kriswest created a review comment on a pull request on finos/FDC3
Because the error message is non-standardized. There doesn't seem any point in enforcing the arbitrary message. Instead I'd rather pursue this in 2.3 and then do it properly: - #1490
kriswest created a review comment on a pull request on finos/FDC3
I intend to remove it and replace with a custom implementation - this was a result of my frustration at not finding a lib for this that would build under both es6 and commonjs. I was going to do th...
kriswest created a comment on a pull request on finos/FDC3
> This is pointing to conformance where really it should be the local appd line (reverse the commenting) Fixing that.
kriswest created a comment on a pull request on finos/FDC3
> Ok, one more UI thing, the default channel appears to be white now, instead of black. But that makes it hard to see against the workbench: ... > Obviously, if workbench was running in dark ...
robmoffat created a comment on a pull request on finos/FDC3
Ok, one more UI thing, the default channel appears to be white now, instead of black. But that makes it hard to see against the workbench: <img width="650" alt="Screenshot 2025-01-13 at 10 50 1...
robmoffat created a comment on a pull request on finos/FDC3
`dummy-desktop-agent.ts`: ``` //await directory.load('/static/da/appd.json'); await directory.load('/static/da/local-conformance-2_0.v2.json'); ``` This is pointing to conformance where...
robmoffat created a review comment on a pull request on finos/FDC3
Have you tested this code? I can't get it to run. If you can't either I suggest we take it out and the index.html file - people will be able to test the channel selector and intent resolver much ...
robmoffat created a review comment on a pull request on finos/FDC3
Why not use the existing 'error with message' and assert that the error matches "Invalid arguments passed to addContextListener!"?
robmoffat created a review comment on a pull request on finos/FDC3
rather than introduce the FDC3Server here, it might be better to have cleanup involve just the ServerContext and MessageHandler classes. setAppState() on the ServerContext can then chain cleanup ...
robmoffat created a review comment on a pull request on finos/FDC3
I'm a bit worried about this license. A lot of FDC3's users have automated tools for license scanning and approvals. If FDC3 suddenly ends up being mixed-license (Apache + ISC) then it may get f...
robmoffat created a review on a pull request on finos/FDC3
Couple of minor issues. The only one stopping me hitting approve is the license for pico colours really. Perhaps you can just add the ANSI codes directly into your logger and remove the dependenc...
robmoffat created a review on a pull request on finos/FDC3
Couple of minor issues. The only one stopping me hitting approve is the license for pico colours really. Perhaps you can just add the ANSI codes directly into your logger and remove the dependenc...
robmoffat created a comment on a pull request on finos/FDC3
> This is a shame - did they say why? > > BTW, the image still exists at: https://github.com/finos/FDC3/blob/pictet-removal/website/static/img/users/pictet.png Against policy apparently.