Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
marioevz created a review comment on a pull request on ethereum/execution-spec-tests
I don't think there is sadly, because the `spec` to `fixture` conversion has always been seen as a one-way street. But see comments in review, it might help this become a bit more stable.
marioevz created a review comment on a pull request on ethereum/execution-spec-tests
I think `Transaction(**fixture_tx,model_dump())` should work with minimal modifications.
marioevz created a review comment on a pull request on ethereum/execution-spec-tests
I think this should focus on the transactions part of the fixture, because, for example, overriding the state root with the one in the original fixture is almost always going to generate an invalid...
marioevz created a review comment on a pull request on ethereum/execution-spec-tests
Maybe even these negative ones are valuable, if they could be wrapped as `eof_test` with an invalid container for negative testing.
marioevz created a review comment on a pull request on ethereum/execution-spec-tests
I have the feeling that doing something like we do here would yield better results maybe: https://github.com/ethereum/execution-spec-tests/blob/0900aa8ef592f968c119f11cdcd934eb2d360693/src/cli/evm...
marioevz created a review on a pull request on ethereum/execution-spec-tests
Looks good! I think we could apply this in a post-fill script. I think @danceratopz might have some comments, and I see one regarding how this could be a pytest plugin, and I agree :smile:
marioevz created a review on a pull request on ethereum/execution-spec-tests
Looks good! I think we could apply this in a post-fill script. I think @danceratopz might have some comments, and I see one regarding how this could be a pytest plugin, and I agree :smile:
marioevz pushed 1 commit to gh-pages ethereum/execution-spec-tests
- Deployed 0900aa8ef to main with MkDocs 1.6.0 and mike 1.1.2 7b36252
marioevz pushed 1 commit to main ethereum/execution-spec-tests
- feat(fill): emphasize that no tests were executed during a fill pytest session (#887) * feat(forks): improve languag... 0900aa8
marioevz closed a pull request on ethereum/execution-spec-tests
feat(fill): emphasize that no tests were executed during a fill pytest session
## 🗒️ Description Changes the terminal output to emphasize that `fill` did not test the client; rather it generated fixtures that can be executed against a client. ### Before ![image](https://...
marioevz created a review on a pull request on ethereum/execution-spec-tests
Still looks good, thanks!