Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
jelias2 created a review comment on a pull request on ethereum-optimism/infra
Thoughts on making ProcessMulticallResponses and ProcessMulticallResponsesWithErrors two different functions?
jelias2 created a review on a pull request on ethereum-optimism/infra
Just curious on the desired outcome/behvaior of this feature, Given a request unique ID, does it intend to return the a success if it exists, otherwise it will return the error response. If...
jelias2 created a review comment on a pull request on ethereum-optimism/infra
Whats the goal here? Is it to add errored responses to the successful responses map that match the same ID? If all the requests have a similar ID of 1, it may not work as intended
jelias2 created a review comment on a pull request on ethereum-optimism/infra
Theres one key thing is that currently we don't allow batch requests in multicall at this point, so all IDs will be most likely 1 ``` if bg.GetRoutingStrategy() == MulticallRoutingStrategy && ...
cody-wang-cb created a review comment on a pull request on ethereum-optimism/infra
I think ID should be unique given it's part of the `handleBatchRPC` flow. It's either the incoming message is a batch request (which should have unique IDs otherwise they wouldn't know how to proce...
danyalprout created a review comment on a pull request on ethereum-optimism/infra
Isn't `multicallRPCErrorCheck` a property on `bg`? Probably don't need to pass it through
cody-wang-cb created a comment on a pull request on ethereum-optimism/infra
@jelias2 @danyalprout PTAL, will add unit tests if this approach seems to make sense
zhwrd created a comment on an issue on ethereum-optimism/infra
merged, will close for now but re-open if its still failing
zhwrd closed an issue on ethereum-optimism/infra
tag service action failing due to github auth
**Bug Description** The tag_service action fails as Github returns a 403 to the bot. **Steps to Reproduce** Run tag service workflow **Additional context** Would be nice if tag_tool and t...
zhwrd closed a pull request on ethereum-optimism/infra
Update tag-service.yml
Was broken because of the global reduction in GitHub token permissions.
cody-wang-cb opened a pull request on ethereum-optimism/infra
Multicall rpc error check
<!-- Contributions welcome! See https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md --> **Description** Add `bool` to have an option that in multicall mode to check all r...
hamdiallam created a comment on an issue on ethereum-optimism/infra
this repo, tagging proxyd/op-txproxy etc. There's a fix for it here though: https://github.com/ethereum-optimism/infra/pull/62
zhwrd created a comment on an issue on ethereum-optimism/infra
@hamdiallam what repo does this refer to? just ran it in optimism and it worked fine.