Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Y-- created a comment on a pull request on duckdb/pg_duckdb
I assume it's not trivial, but could we add a test?
JelteF created a review comment on a pull request on duckdb/pg_duckdb
This low level API was not causing the trigger to be fired. So this PR actually also fixes a bug where the `duckdb.install_extension()` call would not update the sequence, and thus not existing cau...
JelteF pushed 1 commit to default-settings duckdb/pg_duckdb
- Add test for disabled_filesystems=LocalFilestytem 622b54c
JelteF pushed 1 commit to default-settings duckdb/pg_duckdb
- Update src/pgduckdb_duckdb.cpp Co-authored-by: Y. <[email protected]> 92feadd
JelteF created a review comment on a pull request on duckdb/pg_duckdb
Nope `DuckDBQueryOrThrow` currently throws an `elog` not an exception. We probably want to change that in the next release, and we'll need to be careful with all these, but for now this seems total...
JelteF pushed 5 commits to default-settings duckdb/pg_duckdb
- Update default settings 803dc92
- Remove some test failures due to local filesystem 67b041e
- Don't ever set duckdb_disabled_filesystems for superusers 991591e
- Only actually run INSTALL EXTENSION when calling duckdb.install_extension 97994d4
- Make duckdb.install_extension a no-op when the extension is already installed a5ea466
JelteF pushed 13 commits to default-settings duckdb/pg_duckdb
- Add script to load TPC-DS data (#346) This is useful for running quick benchmarks and also to link to in the upcomi... 86f1120
- Don't check if extension is registered in aborted tx (#339) 11734f5
- Support non-superuser usage of pg_duckdb DuckDB is not really designed for use in a multi-user system, and Postgres ... 2356c21
- Add some more tests f6fd3c0
- Address review and make CheckQueryPermissions not return a boolean 422c680
- Resolve security issues reported by pgspot It's really easy to make critical security mistakes in the SQL scripts of... 92d2f6e
- Force schema to public in extension control file for now This gives us the freedom to support more schemas in the fu... d51046e
- Update sql/pg_duckdb--0.0.1.sql Co-authored-by: Jonathan Dance (JD) <[email protected]> c0be188
- Update default settings 45d89b2
- Remove some test failures due to local filesystem c85129b
- Don't ever set duckdb_disabled_filesystems for superusers 93fd876
- Only actually run INSTALL EXTENSION when calling duckdb.install_extension 6aad175
- Make duckdb.install_extension a no-op when the extension is already installed f05ed5f
JelteF pushed 8 commits to pgspot-fixes duckdb/pg_duckdb
- Add script to load TPC-DS data (#346) This is useful for running quick benchmarks and also to link to in the upcomi... 86f1120
- Don't check if extension is registered in aborted tx (#339) 11734f5
- Support non-superuser usage of pg_duckdb DuckDB is not really designed for use in a multi-user system, and Postgres ... 2356c21
- Add some more tests f6fd3c0
- Address review and make CheckQueryPermissions not return a boolean 422c680
- Resolve security issues reported by pgspot It's really easy to make critical security mistakes in the SQL scripts of... 92d2f6e
- Force schema to public in extension control file for now This gives us the freedom to support more schemas in the fu... d51046e
- Update sql/pg_duckdb--0.0.1.sql Co-authored-by: Jonathan Dance (JD) <[email protected]> c0be188
JelteF created a review comment on a pull request on duckdb/pg_duckdb
nah, the other way around. Fixed now.
JelteF pushed 5 commits to non-superuser duckdb/pg_duckdb
- Add script to load TPC-DS data (#346) This is useful for running quick benchmarks and also to link to in the upcomi... 86f1120
- Don't check if extension is registered in aborted tx (#339) 11734f5
- Support non-superuser usage of pg_duckdb DuckDB is not really designed for use in a multi-user system, and Postgres ... 2356c21
- Add some more tests f6fd3c0
- Address review and make CheckQueryPermissions not return a boolean 422c680
JelteF pushed 1 commit to non-superuser duckdb/pg_duckdb
- Address review and make CheckQueryPermissions not return a boolean 30c4b8b
Y-- created a review comment on a pull request on duckdb/pg_duckdb
nit- looks like `superuser()` can be non trivial, so: ```suggestion if (duckdb_disabled_filesystems != NULL && !superuser()) { ```
Y-- created a review comment on a pull request on duckdb/pg_duckdb
Is `ExtensionsTableRelationId` still used somewhere now?
Y-- created a review comment on a pull request on duckdb/pg_duckdb
We need to wrap the call to `DuckdbInstallExtension` in `install_extension` now o/w `duckdb.install_extension('foo')` will crash psql :-)
Y-- created a review comment on a pull request on duckdb/pg_duckdb
Same question here (and below where we have `duckdb.xx`
JelteF pushed 1 commit to default-settings duckdb/pg_duckdb
- Make duckdb.install_extension a no-op when the extension is already installed f917ef4
JelteF pushed 2 commits to default-settings duckdb/pg_duckdb