Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
bleskes pushed 2 commits to readme_tweaks duckdb/pg_duckdb
Y-- created a review comment on a pull request on duckdb/pg_duckdb
Yep it is a no-op, cf. [here](https://github.com/duckdb/duckdb/blob/52b43b166091c82b3f04bf8af15f0ace18207a64/src/main/extension/extension_install.cpp#L538-L548)
JelteF created a review comment on a pull request on duckdb/pg_duckdb
Is `INSTALL` an actual no-op if the extension is already installed? Or does it do something semi-expensive like network requests, which would be good to avoid on every DB initialization.
bleskes pushed 1 commit to readme_tweaks duckdb/pg_duckdb
- Update README.md Co-authored-by: Jelte Fennema-Nio <[email protected]> c7befc3
JelteF created a review comment on a pull request on duckdb/pg_duckdb
nit: This part of the query is now missing some indentation that it had before. I think it looked better with the indentation.
JelteF created a review comment on a pull request on duckdb/pg_duckdb
```suggestion pg_duckdb relies on DuckDB's vectorized execution engine to read and write data to object storage bucket (AWS S3, Cloudflare R2, or Google GCS) and/or MotherDuck. The follow two sect...
JelteF created a review on a pull request on duckdb/pg_duckdb
Some small comments but other than that LGTM.
JelteF created a review on a pull request on duckdb/pg_duckdb
Some small comments but other than that LGTM.
Y-- created a review comment on a pull request on duckdb/pg_duckdb
In the test we insert rows directly in `extensions` table, so we don't run the `install_extension` function. I hesitated using the function or making sure that no matter what we install the extensi...
JelteF created a comment on an issue on duckdb/pg_duckdb
You mean allocate the `values` and `nulls` arrays once? Yeah that seems like an easy perf improvement.
JelteF created a review comment on a pull request on duckdb/pg_duckdb
Interesting, was this not needed before?
JelteF created a review comment on a pull request on duckdb/pg_duckdb
nit: why swap this around? It has no functional difference here right? I checked to see if this is common duckdb style, and generally it seems postfix is preferred: ``` duckdb on main via △ v3....
JelteF pushed 1 commit to main duckdb/pg_duckdb
- Lookup is_null correctly in case of pushed down filters (#322) While running TPCDS queries a few of them crashed Pos... 76872f1
JelteF closed a pull request on duckdb/pg_duckdb
Lookup is_null correctly in case of pushed down filters
While running TPCDS queries a few of them crashed Postgres when using `duckdb.force_execution = true`. It turns out that happened because it would look at the NULL value for the wrong field. This f...
Y-- created a comment on an issue on duckdb/pg_duckdb
Great points. I actually had started re-working the code in here https://github.com/duckdb/pg_duckdb/compare/main...yl/custom-allocator as I had some of the same concerns. (note that this branch wa...