Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AntonioVentilii-DFINITY created a review on a pull request on dfinity/oisy-wallet
LGTM! Nitpick: we have script `check.unused` that should tell you which one are the unused components
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
Can you use the `Button` component here? Or it does not fits the needs?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
can you use `Logo` component here? Or it does not fit the needs?
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
same question about casting here
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
nitpick: `dAppDescriptions.filter(nonNullish)` does it work? eheh
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
do you need the casting? are you not taking elements of `dAppDescriptions`, that I think it's `OisyDappDescription` type?
AntonioVentilii-DFINITY opened a pull request on dfinity/oisy-wallet
style(frontend): smooth transition between group card and token card
# Motivation The svelte animation/transition bases itself on the "ID" given to a specific component. For example, in the Tokens list, the "ID" in the `EACH` loop is given by the `token.id`: ...
AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
style(frontend)/smooth-transition-between-group-card-and-token-card - A browser-based, multi-chain wallet hosted on the Internet Computer
loki344 pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): add badge component (#3104) # Motivation Implement the reusable component 'Badge' from figma. ... d15d197
loki344 closed a pull request on dfinity/oisy-wallet
feat(frontend): add badge component
# Motivation Implement the reusable component 'Badge' from figma.  # Changes - Implement Badge ...
loki344 pushed 9 commits to feat(frontend)/add-badge-component dfinity/oisy-wallet
- feat(frontend): Create listener for multiple tokens (#3040) # Motivation The `TokenGroupCard` component created i... 73f9696
- build(ci): create npm format workflow (#3087) # Motivation Similar to the npm n18i workflow we want the same thin... 97cdcc7
- refactor(frontend): use authNotSignedIn in Listener (#3106) # Motivation It seems cleaner to use `authNotSignedIn... 51cb29f
- feat(frontend): update Carousel styling (#3108) # Motivation The PR has small styling updates of the Carousel com... ee0ee19
- feat(frontend): make DappModal accessible across all routes (#3107) # Motivation This PR is about moving `DappMod... 37430ff
- feat(frontend): Implement token groups in tokens list (#3099) # Motivation We want to start grouping tokens that ... 7444aa1
- refactor(frontend): Extract sub-functions to sum balances (#3113) # Motivation We need to re-use the sub-function... 9ce3a41
- feat(frontend): adjust Carousel initialisation function (#3111) # Motivation While implementing Carousel usages (... aba1c95
- Merge branch 'main' into feat(frontend)/add-badge-component afef2d3
DenysKarmazynDFINITY pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): adjust Carousel initialisation function (#3111) # Motivation While implementing Carousel usages (... aba1c95
DenysKarmazynDFINITY closed a pull request on dfinity/oisy-wallet
feat(frontend): adjust Carousel initialisation function
# Motivation While implementing Carousel usages (2 instances rendered on the token page to comply with the provided design, one for XL screens, another one for smaller ones), I noticed that the ...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Yeah I'm not sure neither, that's why I asked ;) Maybe have a try with your current feature, what happen if a `tag` is super long? Note: I'll approve the PR that's something we can improve in...
DenysKarmazynDFINITY pushed 3 commits to feat(frontend)/adjust-carousel dfinity/oisy-wallet
- feat(frontend): Implement token groups in tokens list (#3099) # Motivation We want to start grouping tokens that ... 7444aa1
- refactor(frontend): Extract sub-functions to sum balances (#3113) # Motivation We need to re-use the sub-function... 9ce3a41
- feat(frontend): adjust Carousel initialisation function 98ce408
loki344 created a review comment on a pull request on dfinity/oisy-wallet
Good point. I could add a text-ellipsis but would expect the consumer to define the width of the badge?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Forgot to ask, one last question: ensuring text are trimmed if too long is repsonsability of consumer of the badge?
loki344 pushed 1 commit to feat(frontend)/add-badge-component dfinity/oisy-wallet
- feat(frontend): MR feedback 6a0c9ba
loki344 created a review comment on a pull request on dfinity/oisy-wallet
I changed it to: `export let variant: keyof typeof variantClassNames = 'default';`