Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
DenysKarmazynDFINITY pushed 3 commits to feat(frontend)/adjust-carousel dfinity/oisy-wallet
- feat(frontend): Implement token groups in tokens list (#3099) # Motivation We want to start grouping tokens that ... 7444aa1
- refactor(frontend): Extract sub-functions to sum balances (#3113) # Motivation We need to re-use the sub-function... 9ce3a41
- feat(frontend): adjust Carousel initialisation function 98ce408
loki344 created a review comment on a pull request on dfinity/oisy-wallet
Good point. I could add a text-ellipsis but would expect the consumer to define the width of the badge?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Forgot to ask, one last question: ensuring text are trimmed if too long is repsonsability of consumer of the badge?
loki344 pushed 1 commit to feat(frontend)/add-badge-component dfinity/oisy-wallet
- feat(frontend): MR feedback 6a0c9ba
loki344 created a review comment on a pull request on dfinity/oisy-wallet
I changed it to: `export let variant: keyof typeof variantClassNames = 'default';`
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Grouping-util-for-token-list dfinity/oisy-wallet
- revert: change Token list back abd6e72
AntonioVentilii-DFINITY pushed 2 commits to feat(frontend)/Grouping-util-for-token-list dfinity/oisy-wallet
AntonioVentilii-DFINITY deleted a branch dfinity/oisy-wallet
refactor(frontend)/Extract-sub-functions-to-sum-balances
AntonioVentilii-DFINITY pushed 1 commit to main dfinity/oisy-wallet
- refactor(frontend): Extract sub-functions to sum balances (#3113) # Motivation We need to re-use the sub-function... 9ce3a41
AntonioVentilii-DFINITY closed a pull request on dfinity/oisy-wallet
refactor(frontend): Extract sub-functions to sum balances
# Motivation We need to re-use the sub-functions of `sumTokenBalances` and `sumTokenUsdBalances`, specifically to provide only the balances instead of the entire token object.
loki344 pushed 1 commit to feat(frontend)/add-badge-component dfinity/oisy-wallet
- feat(frontend): MR feedback e853b15
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
Ah understood, thank you for the clarification! @darioloetsc may you please just test that there are no glitches in the animation/transition with the new ID?
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
> I would rather have a own component Ok
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
There isn't a better way to type this in TypeScript in order to exactly reflects the possible types of the `variableClassNames`?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
This should have been another PR. Anyway, see other comment, it's not a `li` anymore.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Shouldn't it be either a `span` or `li`?
loki344 pushed 1 commit to feat(frontend)/move-wallet-connect-btn dfinity/oisy-wallet
- feat(frontend): MR feedback c99caf5
loki344 created a review comment on a pull request on dfinity/oisy-wallet
Perfect, thank you for linking this issue - It seems as the YourAdresses functionality also does not work on the /explore route, so I have to exclude it there as well.
loki344 created a review comment on a pull request on dfinity/oisy-wallet
You mean the `<WalletConnect/>`? This seems to be a wrapper around different WalletConnectModals, so yes I leave it.
loki344 created a review comment on a pull request on dfinity/oisy-wallet
I'm going with `MenuAddresses `