Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AntonioVentilii-DFINITY opened a draft pull request on dfinity/oisy-wallet
refactor(frontend): Extract sub-functions to sum balances
# Motivation We need to re-use the sub-functions of `sumTokenBalances` and `sumTokenUsdBalances`, specifically to provide only the balances instead of the entire token object.
AntonioVentilii-DFINITY pushed 1 commit to refactor(frontend)/Extract-sub-functions-to-sum-balances dfinity/oisy-wallet
- test: adjust 4599562
AntonioVentilii-DFINITY pushed 1 commit to refactor(frontend)/Extract-sub-functions-to-sum-balances dfinity/oisy-wallet
- revert: remove util 3cdefff
AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
refactor(frontend)/Extract-sub-functions-to-sum-balances - A browser-based, multi-chain wallet hosted on the Internet Computer
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
so, the animation will not understand if they have different id in the list... I imagine @peterpeterparker suggestion was to call the type in a different way, not to give another ID... is that a...
darioloetsc closed a draft pull request on dfinity/oisy-wallet
feat(frontend): Token grouping visuals
# Motivation Display grouped tokens in the list with new visuals. # Changes - Add token group view - Trigger token grouping - Fix styling based on main changes / merge conflicts # Tes...
darioloetsc opened a pull request on dfinity/oisy-wallet
feat(frontend): integrate group store
# Motivation Integrate group store with token group card to enable storing the isExpanded state of the card. # Changes - Rename expanded to isExpanded for consistency - use Symbol.for on ...
darioloetsc pushed 1 commit to feat(frontend)/integrate-group-store dfinity/oisy-wallet
- feat(frontend): format cf93987
darioloetsc pushed 11 commits to feat(frontend)/integrate-group-store dfinity/oisy-wallet
- fix(frontend): Show balance in Token Group Card (#3100) # Motivation To show the balance (and USD balance) of the... 7adaa7a
- build(ci): caching prepare action (#3089) # Motivation Instead of using a new cache in every workflow we cache np... 8110172
- fix(ci): npm i18n adjustments (#3102) # Motivation Fix the issue from the last run # Changes - removed cac... 73bd721
- feat(frontend): Create listener for multiple tokens (#3040) # Motivation The `TokenGroupCard` component created i... 73f9696
- build(ci): create npm format workflow (#3087) # Motivation Similar to the npm n18i workflow we want the same thin... 97cdcc7
- refactor(frontend): use authNotSignedIn in Listener (#3106) # Motivation It seems cleaner to use `authNotSignedIn... 51cb29f
- feat(frontend): update Carousel styling (#3108) # Motivation The PR has small styling updates of the Carousel com... ee0ee19
- feat(frontend): make DappModal accessible across all routes (#3107) # Motivation This PR is about moving `DappMod... 37430ff
- feat(frontend): Implement token groups in tokens list (#3099) # Motivation We want to start grouping tokens that ... 7444aa1
- Merge branch 'main' into feat(frontend)/integrate-group-store # Conflicts: # src/frontend/src/lib/components/tokens/... 725c314
- feat(frontend): merge main Replace Symbol with Symbol.for in group construction to prevent symbols been reinit on ev... ebc4929
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
LGTM, as discussed offline. Thanks.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Too some extention that can be considered as a feature. 😉 But I hear you.
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Good idea, added.
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/dapps-carousel-usage dfinity/oisy-wallet
- feat(frontend): review adjustments 1012257
darioloetsc deleted a branch dfinity/oisy-wallet
feat(frontend)/Implement-token-groups-in-tokens-list
darioloetsc pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): Implement token groups in tokens list (#3099) # Motivation We want to start grouping tokens that ... 7444aa1
darioloetsc closed a pull request on dfinity/oisy-wallet
feat(frontend): Implement token groups in tokens list
# Motivation We want to start grouping tokens that refers to the same underlying. For example `BTC` and `ckBTC`, or `ETH` and `ckETH`. Basically twin tokens, where the "native token" definition ...
darioloetsc pushed 5 commits to feat(frontend)/Implement-token-groups-in-tokens-list dfinity/oisy-wallet
- build(ci): create npm format workflow (#3087) # Motivation Similar to the npm n18i workflow we want the same thin... 97cdcc7
- refactor(frontend): use authNotSignedIn in Listener (#3106) # Motivation It seems cleaner to use `authNotSignedIn... 51cb29f
- feat(frontend): update Carousel styling (#3108) # Motivation The PR has small styling updates of the Carousel com... ee0ee19
- feat(frontend): make DappModal accessible across all routes (#3107) # Motivation This PR is about moving `DappMod... 37430ff
- Merge branch 'main' into feat(frontend)/Implement-token-groups-in-tokens-list 6e55bde
DenysKarmazynDFINITY created a comment on a pull request on dfinity/oisy-wallet
After we merge https://github.com/dfinity/oisy-wallet/pull/3111, the inactive carousel will be just a "div", so memory-wise we should be fine.
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Safari, Firefox, Chrome - ✅ I think IntersectionObserver could lead to some unwanted clearing/initialising processes - if Carousel is rendered and does not have display:none but still out of th...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Same question, does it requires a fade effect?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Does it requires a small `in:fade` effect or it's smooth enough?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Memory wise, it's not too heavy to have this component twice in the DOM at the same time?