Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Memory wise, it's not too heavy to have this component twice in the DOM at the same time?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Does that work in every browser and devices (including mobile phone)? Should we plug quickly an intersection oberserve to be a on the safest side?
darioloetsc pushed 1 commit to feat(frontend)/Implement-token-groups-in-tokens-list dfinity/oisy-wallet
- feat(frontend): add group id be66603
DenysKarmazynDFINITY opened a pull request on dfinity/oisy-wallet
feat(frontend): adjust Carousel initialisation function
# Motivation While implementing Carousel usages (2 instances rendered on the token page to comply with the provided design, one for XL screens, another one for smaller ones), I noticed that the ...
DenysKarmazynDFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/adjust-carousel - A browser-based, multi-chain wallet hosted on the Internet Computer
darioloetsc created a review comment on a pull request on dfinity/oisy-wallet
I agree with you that the ID should be typed separately. This shortcut was taken because downward elements, like the stores, are typed to tokenid. I suggest adding the type groupId = tokenId and cl...
DenysKarmazynDFINITY opened a pull request on dfinity/oisy-wallet
feat(frontend): DappsCarousel usage (all screen sizes)
# Motivation In this PR, DappsCarousel have been added to NavigationMenu (displayed on xl screens) and Tokens page layout (displayed on >= lg screens). For now, the carousel should be rendered o...
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/dapps-carousel-usage dfinity/oisy-wallet
- feat(frontend): DappsCarousel usage (all screen sizes) 14951ca
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/dapps-carousel-usage dfinity/oisy-wallet
- feat(frontend): DappsCarousel usage (all screen sizes) dcf0e68
DenysKarmazynDFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/dapps-carousel-usage - A browser-based, multi-chain wallet hosted on the Internet Computer
DenysKarmazynDFINITY opened a pull request on dfinity/oisy-wallet
feat(frontend): DappsCarousel components
# Motivation This PR includes DappsCarousel components. https://github.com/user-attachments/assets/3a474efe-4a3b-45c7-895f-02591836f3ed
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/dapps-carousel dfinity/oisy-wallet
- feat(frontend): DappsCarousel components d434b8a
DenysKarmazynDFINITY created a branch on dfinity/oisy-wallet
feat(frontend)/dapps-carousel - A browser-based, multi-chain wallet hosted on the Internet Computer
DenysKarmazynDFINITY pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): make DappModal accessible across all routes (#3107) # Motivation This PR is about moving `DappMod... 37430ff
DenysKarmazynDFINITY closed a pull request on dfinity/oisy-wallet
feat(frontend): make DappModal accessible across all routes
# Motivation This PR is about moving `DappModal` from `DappsExplorerSignedIn` to global `Modals` so the modal can be opened from different places (e.g. list item on the explorer page, carousel s...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
But in that case `id: TokenId` is not really correct since a group is a not a token. I guess that's my confusion. Should the `id` be just defined as `symbol` in `TokenUiOrGroupUi`? Does that make s...
DenysKarmazynDFINITY pushed 11 commits to feat(frontend)/dapp-modal-accessibility dfinity/oisy-wallet
- fix(ci): adjusted checkout and pull strategy (#3085) # Motivation The last run of the auto update failed because ... db2699a
- chore(frontend): Remove unused prop of TokenUiGroup (#3098) # Motivation We remove the props that are not needed ... 2ceff17
- test(frontend): Use Sepolia token for card tests (#3101) # Motivation Since ICP token name is the same as ICP net... 405d1f5
- fix(frontend): Show balance in Token Group Card (#3100) # Motivation To show the balance (and USD balance) of the... 7adaa7a
- build(ci): caching prepare action (#3089) # Motivation Instead of using a new cache in every workflow we cache np... 8110172
- fix(ci): npm i18n adjustments (#3102) # Motivation Fix the issue from the last run # Changes - removed cac... 73bd721
- feat(frontend): Create listener for multiple tokens (#3040) # Motivation The `TokenGroupCard` component created i... 73f9696
- build(ci): create npm format workflow (#3087) # Motivation Similar to the npm n18i workflow we want the same thin... 97cdcc7
- refactor(frontend): use authNotSignedIn in Listener (#3106) # Motivation It seems cleaner to use `authNotSignedIn... 51cb29f
- feat(frontend): update Carousel styling (#3108) # Motivation The PR has small styling updates of the Carousel com... ee0ee19
- feat(frontend): make DappModal accessible across all routes 6be2363
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Ah, got it. Yeah, let's do it in a new PR.
AntonioVentilii-DFINITY created a review comment on a pull request on dfinity/oisy-wallet
it is needed as direct prop of `TokenUiGroup` because when we list the "assets" (either `TokenUi` or `TokenUiGroup`), we index it given the ID, both for the `EACH` loop and for the transitions/anim...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Indeed ;) For example `SendButtonWithModal` - see the `const modalId = Symbol();` ``` <script lang="ts"> import SendButton from '$lib/components/send/SendButton.svelte'; import { modalSt...