Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
inc-man pushed 1 commit to main dfinity/oisy-wallet
- build(ci): adjust paths in i18n workflow (#3078) # Motivation Change the path to the same layout as the backend t... b3972dd
inc-man closed a pull request on dfinity/oisy-wallet
build(ci): adjust paths in i18n workflow
# Motivation Change the path to the same layout as the backend tests # Changes - changed paths
inc-man pushed 7 commits to build(ci)/npm-i18n-workflow dfinity/oisy-wallet
- style(frontend): add bg for loading phase of dapp promo banner (#3072) # Motivation The buttons and text of the D... af9c77d
- refactor(frontend): Move gap among token cards in the list (#3074) # Motivation To make TokenCards more re-usable... 7fe9fa1
- feat(frontend): Carousel utils (#3067) # Motivation This PR includes utils needed for the Carousel component. The... 4dd4d6c
- refactor(frontend): Limit data provided to token cards (#3079) # Motivation We want to re-use TokenCard and its r... f7daa3f
- chore(e2e): Update Playwright E2E Snapshots (#3080) The following E2E snapshots have been updated: ``` e2e/homepag... b6ba1dc
- feat(frontend): simple token group store (#3070) # Motivation Introduce a token group store to preserve expanded ... c2c9965
- Merge branch 'main' into build(ci)/npm-i18n-workflow c202a01
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Maybe I should have blocked this - i.e. as mentionned [above](https://github.com/dfinity/oisy-wallet/pull/3070#discussion_r1812872179), why are we using a certified store?
darioloetsc closed a pull request on dfinity/oisy-wallet
feat(frontend): simple token group store
# Motivation Introduce a token group store to preserve expanded settings in the grouping view. # Changes Add token group store. # Tests
darioloetsc pushed 13 commits to feat(frontend)/simple-token-group-store dfinity/oisy-wallet
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- feat(frontend): Include balances in token group (#3062) # Motivation Another useful PR for grouping tokens: we ne... 605c550
- feat(frontend): enhance dapp modal (#3068) # Motivation Integrate testing feedback: More social links, styling is... 9f4ea08
- fix(ci): fix release process automation (#3066) # Motivation During previous runs the new release branch was set ... 70c1e76
- build(ci): create npm i18n workflow (#3073) # Motivation For every pr and pr commit where the i18n files are chan... 6258d61
- refactor(frontend): Rename type for token groups (#3075) # Motivation As discussed, the more obvious name for the... a057f24
- style(frontend): Increase breakpoint for mobile view (#3077) # Motivation As a recent feedback, we are increasing... a81dcb0
- style(frontend): add bg for loading phase of dapp promo banner (#3072) # Motivation The buttons and text of the D... af9c77d
- refactor(frontend): Move gap among token cards in the list (#3074) # Motivation To make TokenCards more re-usable... 7fe9fa1
- feat(frontend): Carousel utils (#3067) # Motivation This PR includes utils needed for the Carousel component. The... 4dd4d6c
- refactor(frontend): Limit data provided to token cards (#3079) # Motivation We want to re-use TokenCard and its r... f7daa3f
- chore(e2e): Update Playwright E2E Snapshots (#3080) The following E2E snapshots have been updated: ``` e2e/homepag... b6ba1dc
- Merge branch 'main' into feat(frontend)/simple-token-group-store 17195b7
peterpeterparker opened a draft pull request on dfinity/oisy-wallet
chore(local): review ICP ledger and index version
# Motivation I updated Juno Docker and noticed that actually a version of the ICP index and ledger was proposed and executed after the IC repo was renamed (`rosetta-api` -> `ledger_suite`). Ther...
peterpeterparker created a branch on dfinity/oisy-wallet
chore/review-icp-commit-version - A browser-based, multi-chain wallet hosted on the Internet Computer
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
I will keep it in mind while implementing the next step where I actually use the component. I think it won't be a big deal to adjust some values to be dynamic, but in general your point totally mak...
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
What I mean is, if I understand correctly, the carousel will work fine as long as there are no dynamic changes to its content, like adding or removing slides. I'm also not sure how it would behave ...
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
LGTM, thanks I'm approving the PR, but as mentioned in my comments, I believe that the fact this component does not seem to support dynamic re-rendering could potentially lead to issues and cost...
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
LGTM, thanks I'm approving the PR, but as mentioned in my comments, I believe that the fact this component does not seem to support dynamic re-rendering could potentially lead to issues and cost...
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/carousel-component dfinity/oisy-wallet
- feat(frontend): check for empty string 6b17e15
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/carousel-component dfinity/oisy-wallet
- feat(frontend): add comment 1700fd4
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Adding now, missed this comment.
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/carousel-component dfinity/oisy-wallet
- feat(frontend): review adjustments dcdefd5
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
In this case, I would keep defining containerWidth onMount (right before we generate the frame).
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Done in this case.
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
I don't think it can be the case, I added that check mostly to attempt to prevent the above mentioned desynchronization. If it looks confusing, I can remove it.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Oh that's another thing that needs to be documented - if a slide gets removed dynamically after everything is mounted then I guess the all slider is broken?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Same as my other comment, I meant: ``` let totalSlides: number; $: totalSlides = slides?.length ?? 0 ``` Is this interesting here?