Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
What I mean was: ``` let containerWidth = 0; $: containerWidth = container?.offsetWidth ?? 0 ``` Would a less imperactive approach be interesting here?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Did not knew, thought in Svelte v4 onDestroy was required. Cool.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Can you add a comment somewhere because this is kind of a limitation.
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
I added a small check to see if sliderFrame includes slides, couldn't come up with any other solutions here
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/carousel-component dfinity/oisy-wallet
- feat(frontend): review adjustments 622ba2b
DenysKarmazynDFINITY pushed 1 commit to feat(frontend)/carousel-component dfinity/oisy-wallet
- feat(frontend): review adjustments 0e17d29
DenysKarmazynDFINITY pushed 31 commits to feat(frontend)/carousel-component dfinity/oisy-wallet
- chore(e2e): Update Playwright E2E Snapshots (#3049) The following E2E snapshots have been updated: ``` e2e/homepag... 98d1a3b
- feat(frontend): remove header Back (#3048) # Motivation The new route behavior `/explore` introduced an inconsist... 7a6bd36
- feat(frontend): review address block (#3013) # Motivation We want to redesign a bit the address we present in mod... ebbe821
- feat(frontend): display token as logo above qr-code (#3023) # Motivation The designers want to display the token ... 224f2de
- chore(e2e): Update Playwright E2E Snapshots (#3056) The following E2E snapshots have been updated: ``` e2e/receive... 5520de2
- test(frontend): Add test ID for token group in TokenCard (#3052) # Motivation The component `TokenCard` will be r... 696ce03
- refactor(build): Change tailwind config to Typescript (#3051) # Motivation Just to use more Typescript, we change... d74de9a
- feat(frontend): Remove redundant prop to show back button in Hero (#3055) # Motivation The `Back` button showed i... 1559078
- refactor(frontend): Include native token in token group property (#3043) # Motivation It is useful to have the na... 875f219
- chore(frontend): format i18n type file (#3050) # Motivation Maybe in some PR, an unformatted `i18n` type file sli... e2c6553
- feat(frontend): Provide token count in Token logo (#3041) # Motivation For PR #3028, to group tokens, we want to ... 68d7756
- refactor(frontend): extract qr code address content component (#3058) # Motivation Two components that display a ... 8ccc407
- feat(frontend): qr code min height to prevent modal glitch (#3057) # Motivation The QR code has no minimum height... f83f883
- feat(frontend): Introduce OisySymbol prop for appearence interface (#3053) # Motivation For grouping tokens, we a... 51609a5
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- feat(frontend): Include balances in token group (#3062) # Motivation Another useful PR for grouping tokens: we ne... 605c550
- and 11 more ...
peterpeterparker pushed 1 commit to style/update-animation dfinity/oisy-wallet
- feat: cleanup f441336
peterpeterparker opened a pull request on dfinity/oisy-wallet
style(frontend): update astronaut eyes icon animation
# Motivation Artem has updated the speed/style of the animation of the eyes of the animated astronaut in his codepen: https://codepen.io/Artem-Korotkikh/pen/xxvXMwW?editors=1010 This PR refle...
peterpeterparker created a branch on dfinity/oisy-wallet
style/update-animation - A browser-based, multi-chain wallet hosted on the Internet Computer
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
this can go in a util in another PR. like `mapGroupToCardData`
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
`isExpanded` for consistency? I noticed that term used in another PR.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Unrelated to this PR: just realized that `subLogo` could potentially be called `badge`.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Should `tokenCount` actually becomes an optional variable or `CardData`?
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
There is a check in `onNext`/`onPrevious` functions. `goToNextSlide` is indeed also used directly by the autoplay timer, but the overflow won't happen because of the next lines of this method - it ...
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
True, adjusted.
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
Since `container` is initially `undefined`, I added this var to avoid `nonNullish` check in every place where we need this value. Plus, it can only change on mount and on resize (both events will t...
AntonioVentilii-DFINITY pushed 1 commit to main dfinity/oisy-wallet
- chore(e2e): Update Playwright E2E Snapshots (#3080) The following E2E snapshots have been updated: ``` e2e/homepag... b6ba1dc
AntonioVentilii-DFINITY closed a pull request on dfinity/oisy-wallet
chore(e2e): Update Playwright E2E Snapshots
The following E2E snapshots have been updated: ``` e2e/homepage.spec.ts-snapshots/should-display-homepage-in-logged-in-state-1-Google-Chrome-linux.png
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- fix: correct merge e08bfea
DenysKarmazynDFINITY created a review comment on a pull request on dfinity/oisy-wallet
It's used in 5 different places, so `totalSlides` is just a shortcut for `slides.length`. No strong opinion here, I can remove the var if you prefer so.
sa-github-api created a branch on dfinity/oisy-wallet
bot-e2e-update-snapshots - A browser-based, multi-chain wallet hosted on the Internet Computer
