Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AntonioVentilii-DFINITY opened a pull request on dfinity/oisy-wallet
refactor(frontend): Rename type for token groups
# Motivation As discussed, the more obvious name for the variable should be `TokenUiGroup` since it is a group of `TokenUi` types.
loki344 pushed 1 commit to style(frontend)/dapp-promo-banner-bg dfinity/oisy-wallet
- style(frontend): format c845525
AntonioVentilii-DFINITY pushed 1 commit to refactor(frontend)/Move-gap-among-token-cards-in-the-list dfinity/oisy-wallet
- add margin 17b2ca8
AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
refactor(frontend)/Rename-type-for-token-groups - A browser-based, multi-chain wallet hosted on the Internet Computer
loki344 pushed 1 commit to style(frontend)/dapp-promo-banner-bg dfinity/oisy-wallet
- style(frontend): improve backdrop b1afbfa
AntonioVentilii-DFINITY opened a pull request on dfinity/oisy-wallet
refactor(frontend): Move gap among token cards in the list
# Motivation To make TokenCards more re-usable, it would be better to put the spacing among themselves outside the components per-se. So, in this PR we keep that spacing but we move it in the li...
inc-man opened a pull request on dfinity/oisy-wallet
build(ci): create npm i18n workflow
# Motivation For every pr and pr commit where the i18n files are changed, the npm run i18n should be executed and auto commited. # Changes - created workflow
AntonioVentilii-DFINITY created a branch on dfinity/oisy-wallet
refactor(frontend)/Move-gap-among-token-cards-in-the-list - A browser-based, multi-chain wallet hosted on the Internet Computer
inc-man created a branch on dfinity/oisy-wallet
build(ci)/npm-i18n-workflow - A browser-based, multi-chain wallet hosted on the Internet Computer
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- lint: fix imports 66728bc
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- refactor: consider group card unique fb4f1f9
loki344 pushed 1 commit to style(frontend)/dapp-promo-banner-bg dfinity/oisy-wallet
- style(frontend): add bg for loading phase of dapp promo banner d7ce1d8
loki344 opened a draft pull request on dfinity/oisy-wallet
style(frontend): add bg for loading phase of dapp promo banner
# Motivation The buttons and text of the DappPromoBanner are not visible during loading of the image. A simple grey background is enough to provide contrast. # Changes - Add grey backgroun...
loki344 created a branch on dfinity/oisy-wallet
style(frontend)/dapp-promo-banner-bg - A browser-based, multi-chain wallet hosted on the Internet Computer
loki344 closed a pull request on dfinity/oisy-wallet
feat(frontend): enhance dapp modal
# Motivation Integrate testing feedback: More social links, styling issue of image on small screens. # Changes - Integrate new social links with icons. - Fix Image height before: <...
loki344 pushed 2 commits to feat(frontend)/enhance-dapp-modal dfinity/oisy-wallet
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
nitpick: `<slot />`
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Have you thhought to passing the animation as an option of `goToSlide` to avoid having to enable or disable before the going to the slide? ``` goToSlide({ slide: 0, transition: none }) ```
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Should we prevent overflow?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
nitpick: I think `clearInterval` actually acccepts `undefined` parameter
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Shouldn't we derive `containerWidth` from the container rather than imperatively setting it's value?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Would something like `container.replaceChild` would work instead of resetting and appending?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Many things need to be initialized, I'm a bit afraid we end up in a partial state in which some information are set and some not. Should we prevent those kind of desynchronization?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Why not derive `totalSlides` from `slides`?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Should we rather extract this in a dedicated initialization function?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
We generally use `<svelte:window>` to register global events
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
In Svelte4, returning a function here works similarly as an `onDestroy` hook?