Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Should we prevent overflow?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
nitpick: I think `clearInterval` actually acccepts `undefined` parameter
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Shouldn't we derive `containerWidth` from the container rather than imperatively setting it's value?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Would something like `container.replaceChild` would work instead of resetting and appending?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Many things need to be initialized, I'm a bit afraid we end up in a partial state in which some information are set and some not. Should we prevent those kind of desynchronization?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Why not derive `totalSlides` from `slides`?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Should we rather extract this in a dedicated initialization function?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
We generally use `<svelte:window>` to register global events
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
In Svelte4, returning a function here works similarly as an `onDestroy` hook?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
The carousel is not dynamic and can only be initialized once, is this expected?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Not sure if I was supposed to review this one but, as it is tight with #3067, I also had a first look.
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Not sure if I was supposed to review this one but, as it is tight with #3067, I also had a first look.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
We clone the slide? Shouldn't we just move those?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
It needs a width even if each slides is already defined with their width?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Do we need to create this element? It can be an existing reference?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
`append()` or something like that accept appending multiple elements at one - no need of `forEach`
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
should we prevent division by zero?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
A first round of comments 😉
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
A first round of comments 😉
darioloetsc created a comment on a pull request on dfinity/oisy-wallet
> I think there was a misunderstanding: your first iteration was ok, I would have just used the `initCertifiedSetterStore` > > So, that the definition would have been > > ```ts > export inte...
darioloetsc pushed 1 commit to feat(frontend)/simple-token-group-store dfinity/oisy-wallet
- feat(frontend): remove unnecessary data type eff256b
loki344 created a review comment on a pull request on dfinity/oisy-wallet
yup Uploading Bildschirmaufnahme 2024-10-23 um 14.46.20.mov…
loki344 created a comment on a pull request on dfinity/oisy-wallet
> Does it still looks good if the title and url are longer than in the provided screenshots? yup, added a flex wrap for this: <img width="526" alt="image" src="https://github.com/user-attachme...
darioloetsc pushed 3 commits to feat(frontend)/token-grouping-r7 dfinity/oisy-wallet
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- feat: change size of logo 0f7787d
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Did you double checked that if the network is slow the change does not result in elements shift in the UI? Asking just to be sure everything remains still in place.
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Does it still looks good if the title and url are longer than in the provided screenshots? <img width="555" alt="379193860-518ee862-15bd-4eba-845a-cdb2cb4beb98" src="https://github.com/user-atta...
AntonioVentilii-DFINITY pushed 2 commits to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet