Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
The carousel is not dynamic and can only be initialized once, is this expected?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Not sure if I was supposed to review this one but, as it is tight with #3067, I also had a first look.
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
Not sure if I was supposed to review this one but, as it is tight with #3067, I also had a first look.
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
We clone the slide? Shouldn't we just move those?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
It needs a width even if each slides is already defined with their width?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Do we need to create this element? It can be an existing reference?
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
`append()` or something like that accept appending multiple elements at one - no need of `forEach`
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
should we prevent division by zero?
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
A first round of comments 😉
peterpeterparker created a review on a pull request on dfinity/oisy-wallet
A first round of comments 😉
darioloetsc created a comment on a pull request on dfinity/oisy-wallet
> I think there was a misunderstanding: your first iteration was ok, I would have just used the `initCertifiedSetterStore` > > So, that the definition would have been > > ```ts > export inte...
darioloetsc pushed 1 commit to feat(frontend)/simple-token-group-store dfinity/oisy-wallet
- feat(frontend): remove unnecessary data type eff256b
loki344 created a review comment on a pull request on dfinity/oisy-wallet
yup Uploading Bildschirmaufnahme 2024-10-23 um 14.46.20.mov…
loki344 created a comment on a pull request on dfinity/oisy-wallet
> Does it still looks good if the title and url are longer than in the provided screenshots? yup, added a flex wrap for this: <img width="526" alt="image" src="https://github.com/user-attachme...
darioloetsc pushed 3 commits to feat(frontend)/token-grouping-r7 dfinity/oisy-wallet
AntonioVentilii-DFINITY pushed 1 commit to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- feat: change size of logo 0f7787d
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Did you double checked that if the network is slow the change does not result in elements shift in the UI? Asking just to be sure everything remains still in place.
peterpeterparker created a comment on a pull request on dfinity/oisy-wallet
Does it still looks good if the title and url are longer than in the provided screenshots? <img width="555" alt="379193860-518ee862-15bd-4eba-845a-cdb2cb4beb98" src="https://github.com/user-atta...
AntonioVentilii-DFINITY pushed 2 commits to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
AntonioVentilii-DFINITY pushed 1 commit to main dfinity/oisy-wallet
- feat(frontend): Include balances in token group (#3062) # Motivation Another useful PR for grouping tokens: we ne... 605c550
AntonioVentilii-DFINITY deleted a branch dfinity/oisy-wallet
feat(frontend)/Include-balances-in-token-group
AntonioVentilii-DFINITY closed a pull request on dfinity/oisy-wallet
feat(frontend): Include balances in token group
# Motivation Another useful PR for grouping tokens: we need to have the balances (both token and USD) for each group. Note that for nullish values for both tokens in group, we keep them as they ...
AntonioVentilii-DFINITY pushed 6 commits to feat(frontend)/Card-component-for-Token-Group dfinity/oisy-wallet
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- Merge branch 'main' into feat(frontend)/Card-component-for-Token-Group d502215
AntonioVentilii-DFINITY pushed 7 commits to feat(frontend)/Include-balances-in-token-group dfinity/oisy-wallet
- feat(frontend): Introduce OisySymbol prop for appearence interface (#3053) # Motivation For grouping tokens, we a... 51609a5
- feat(frontend): Use Network wallets for Onramper Widget (#2833) # Motivation As Security review suggested, it is ... 2e014c5
- fix(ci): fix run-name and remove ic (#3059) # Motivation We don't need the workflow to deploy to ic, since we do ... 0ba903d
- feat(frontend): network icon black white for receive (#3064) # Motivation The network icon displayed in the recei... 9fb3226
- feat(frontend): receive modal title with symbol (#3036) # Motivation The designers want to display the token symb... 31612ac
- feat(frontend): enhance dapp data (#3063) # Motivation The Design-Team added more social links and new images for... 885772a
- Merge branch 'main' into feat(frontend)/Include-balances-in-token-group bd2df08
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
I just meant: - Should a button be disabled when it is set as "loading"? - Can a button be set as "disabled" and "loading" at the same time?
loki344 created a comment on a pull request on dfinity/oisy-wallet
Or.. use a existing library instead..? https://www.embla-carousel.com/examples/predefined/#auto-scroll
peterpeterparker created a review comment on a pull request on dfinity/oisy-wallet
Makes sense, thanks for the explanation.